ti-icdi: catch failed icdi_send_cmd 80/1180/2
authorSpencer Oliver <spen@spen-soft.co.uk>
Mon, 25 Feb 2013 15:45:12 +0000 (15:45 +0000)
committerFreddie Chopin <freddie.chopin@gmail.com>
Wed, 6 Mar 2013 20:24:24 +0000 (20:24 +0000)
warnings detected by clang.

Change-Id: I1532bcc12a8ab7446646dfb2a7afa8894ff03679
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/1180
Tested-by: jenkins
Reviewed-by: Xiaofan <xiaofanc@gmail.com>
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>
src/jtag/drivers/ti_icdi_usb.c

index 672952237153e3aa6bc201888d0cd75b7094e73c..dcffd2fba02e7f0d3aface879304d93edc78869b 100644 (file)
@@ -346,6 +346,8 @@ static int icdi_usb_query(void *handle)
        h = (struct icdi_usb_handle_s *)handle;
 
        result = icdi_send_cmd(handle, "qSupported");
+       if (result != ERROR_OK)
+               return result;
 
        /* check result */
        result = icdi_get_cmd_result(handle);
@@ -412,6 +414,8 @@ static int icdi_usb_run(void *handle)
 
        /* resume target at current address */
        result = icdi_send_cmd(handle, "c");
+       if (result != ERROR_OK)
+               return result;
 
        /* check result */
        result = icdi_get_cmd_result(handle);
@@ -429,6 +433,8 @@ static int icdi_usb_halt(void *handle)
 
        /* this query halts the target ?? */
        result = icdi_send_cmd(handle, "?");
+       if (result != ERROR_OK)
+               return result;
 
        /* check result */
        result = icdi_get_cmd_result(handle);
@@ -446,6 +452,8 @@ static int icdi_usb_step(void *handle)
 
        /* step target at current address */
        result = icdi_send_cmd(handle, "s");
+       if (result != ERROR_OK)
+               return result;
 
        /* check result */
        result = icdi_get_cmd_result(handle);

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)