mips32_comparator_t -> struct mips32_comparator
authorZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 16:43:26 +0000 (08:43 -0800)
committerZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 19:58:11 +0000 (11:58 -0800)
Remove misleading typedef and redundant suffix from struct mips32_comparator.

src/target/mips32.c
src/target/mips32.h
src/target/mips_m4k.c

index 055d2788051c9c4f5b754ec8ba9e833bd8c8b1c6..c8e47aac1a78c47a2299ea52e09e5874c2270bf9 100644 (file)
@@ -384,7 +384,7 @@ int mips32_configure_break_unit(struct target_s *target)
 
                mips32->num_inst_bpoints = (bpinfo >> 24) & 0x0F;
                mips32->num_inst_bpoints_avail = mips32->num_inst_bpoints;
 
                mips32->num_inst_bpoints = (bpinfo >> 24) & 0x0F;
                mips32->num_inst_bpoints_avail = mips32->num_inst_bpoints;
-               mips32->inst_break_list = calloc(mips32->num_inst_bpoints, sizeof(mips32_comparator_t));
+               mips32->inst_break_list = calloc(mips32->num_inst_bpoints, sizeof(struct mips32_comparator));
                for (i = 0; i < mips32->num_inst_bpoints; i++)
                {
                        mips32->inst_break_list[i].reg_address = EJTAG_IBA1 + (0x100 * i);
                for (i = 0; i < mips32->num_inst_bpoints; i++)
                {
                        mips32->inst_break_list[i].reg_address = EJTAG_IBA1 + (0x100 * i);
@@ -403,7 +403,7 @@ int mips32_configure_break_unit(struct target_s *target)
 
                mips32->num_data_bpoints = (bpinfo >> 24) & 0x0F;
                mips32->num_data_bpoints_avail = mips32->num_data_bpoints;
 
                mips32->num_data_bpoints = (bpinfo >> 24) & 0x0F;
                mips32->num_data_bpoints_avail = mips32->num_data_bpoints;
-               mips32->data_break_list = calloc(mips32->num_data_bpoints, sizeof(mips32_comparator_t));
+               mips32->data_break_list = calloc(mips32->num_data_bpoints, sizeof(struct mips32_comparator));
                for (i = 0; i < mips32->num_data_bpoints; i++)
                {
                        mips32->data_break_list[i].reg_address = EJTAG_DBA1 + (0x100 * i);
                for (i = 0; i < mips32->num_data_bpoints; i++)
                {
                        mips32->data_break_list[i].reg_address = EJTAG_DBA1 + (0x100 * i);
index 476b76882fb3370717aa8cf330a883e38b311014..5398ddf7fef255a0604d0dd257e577c34ca7de74 100644 (file)
@@ -37,13 +37,13 @@ enum
        MIPS32NUMCOREREGS
 };
 
        MIPS32NUMCOREREGS
 };
 
-typedef struct mips32_comparator_s
+struct mips32_comparator
 {
        int used;
        //int type;
        uint32_t bp_value;
        uint32_t reg_address;
 {
        int used;
        //int type;
        uint32_t bp_value;
        uint32_t reg_address;
-} mips32_comparator_t;
+};
 
 typedef struct mips32_common_s
 {
 
 typedef struct mips32_common_s
 {
@@ -58,8 +58,8 @@ typedef struct mips32_common_s
        int num_data_bpoints;
        int num_inst_bpoints_avail;
        int num_data_bpoints_avail;
        int num_data_bpoints;
        int num_inst_bpoints_avail;
        int num_data_bpoints_avail;
-       mips32_comparator_t *inst_break_list;
-       mips32_comparator_t *data_break_list;
+       struct mips32_comparator *inst_break_list;
+       struct mips32_comparator *data_break_list;
 
        /* register cache to processor synchronization */
        int (*read_core_reg)(struct target_s *target, int num);
 
        /* register cache to processor synchronization */
        int (*read_core_reg)(struct target_s *target, int num);
index 0fc32ab8798843d7a4b8f23ce5093032bd9feefa..df9ec4143f92c8001589818286fdb90f54e3920e 100644 (file)
@@ -494,7 +494,7 @@ void mips_m4k_enable_breakpoints(struct target_s *target)
 int mips_m4k_set_breakpoint(struct target_s *target, breakpoint_t *breakpoint)
 {
        mips32_common_t *mips32 = target->arch_info;
 int mips_m4k_set_breakpoint(struct target_s *target, breakpoint_t *breakpoint)
 {
        mips32_common_t *mips32 = target->arch_info;
-       mips32_comparator_t * comparator_list = mips32->inst_break_list;
+       struct mips32_comparator * comparator_list = mips32->inst_break_list;
        int retval;
 
        if (breakpoint->set)
        int retval;
 
        if (breakpoint->set)
@@ -586,7 +586,7 @@ int mips_m4k_unset_breakpoint(struct target_s *target, breakpoint_t *breakpoint)
 {
        /* get pointers to arch-specific information */
        mips32_common_t *mips32 = target->arch_info;
 {
        /* get pointers to arch-specific information */
        mips32_common_t *mips32 = target->arch_info;
-       mips32_comparator_t * comparator_list = mips32->inst_break_list;
+       struct mips32_comparator * comparator_list = mips32->inst_break_list;
        int retval;
 
        if (!breakpoint->set)
        int retval;
 
        if (!breakpoint->set)
@@ -702,7 +702,7 @@ int mips_m4k_remove_breakpoint(struct target_s *target, breakpoint_t *breakpoint
 int mips_m4k_set_watchpoint(struct target_s *target, struct watchpoint *watchpoint)
 {
        mips32_common_t *mips32 = target->arch_info;
 int mips_m4k_set_watchpoint(struct target_s *target, struct watchpoint *watchpoint)
 {
        mips32_common_t *mips32 = target->arch_info;
-       mips32_comparator_t * comparator_list = mips32->data_break_list;
+       struct mips32_comparator * comparator_list = mips32->data_break_list;
        int wp_num = 0;
        /*
         * watchpoint enabled, ignore all byte lanes in value register
        int wp_num = 0;
        /*
         * watchpoint enabled, ignore all byte lanes in value register
@@ -771,7 +771,7 @@ int mips_m4k_unset_watchpoint(struct target_s *target, struct watchpoint *watchp
 {
        /* get pointers to arch-specific information */
        mips32_common_t *mips32 = target->arch_info;
 {
        /* get pointers to arch-specific information */
        mips32_common_t *mips32 = target->arch_info;
-       mips32_comparator_t * comparator_list = mips32->data_break_list;
+       struct mips32_comparator * comparator_list = mips32->data_break_list;
 
        if (!watchpoint->set)
        {
 
        if (!watchpoint->set)
        {

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)