CFI CORE: bug-fix protect single sector
authorAntonio Borneo <borneo.antonio@gmail.com>
Mon, 8 Mar 2010 16:43:59 +0000 (00:43 +0800)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Tue, 9 Mar 2010 21:54:40 +0000 (22:54 +0100)
Cannot protect or unprotect single sector in cfi flash.
When first==last the procedure fails.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
src/flash/nor/core.c

index 767006d27e10003190b7cf4b1a4df20661c76126..8b581b0c5ad752fff5080fe65e3cc81e0e7172c0 100644 (file)
@@ -73,7 +73,7 @@ int flash_driver_protect(struct flash_bank *bank, int set, int first, int last)
         * speeds at least some things up.
         */
 scan:
-       for (int i = first; i < last; i++) {
+       for (int i = first; i <= last; i++) {
                struct flash_sector *sector = bank->sectors + i;
 
                /* Only filter requests to protect the already-protected, or
@@ -108,7 +108,7 @@ scan:
        }
 
        /* Single sector, already protected?  Nothing to do! */
-       if (first == last)
+       if (first > last)
                return ERROR_OK;
 
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)