dsp563xx_once: Correct definition of JTAG_INSTR_CLAMP
authorPhil Fong <fongpwf@yahoo.com>
Tue, 15 Feb 2011 19:17:33 +0000 (20:17 +0100)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Tue, 15 Feb 2011 19:17:33 +0000 (20:17 +0100)
 I've been working on Rodrigo on adding support to flash
Freescale dsp56800e devices and have been looking at the
dsp563xx code.  I think the define for the JTAG CLAMP
instruction in dsp563xx_once.c is incorrect.  It should
be 0x05 according the Freescale AN2074 (and is also
0x05 in the dsp568xx according to AN1935).  It won't
actually change anything in OpenOCD since this define
is not used anywhere (as far as I can tell).

src/target/dsp563xx_once.c

index cb3abf66fbe0f66a68934f69a9e14e551ef449cc..ddd06dde6913e6a3cec6d0df4fd100befd1f4ee8 100644 (file)
@@ -37,8 +37,8 @@
 #define JTAG_INSTR_EXTEST              0x00
 #define JTAG_INSTR_SAMPLE_PRELOAD      0x01
 #define JTAG_INSTR_IDCODE              0x02
-#define JTAG_INSTR_CLAMP               0x03
 #define JTAG_INSTR_HIZ                 0x04
+#define JTAG_INSTR_CLAMP               0x05
 #define JTAG_INSTR_ENABLE_ONCE         0x06
 #define JTAG_INSTR_DEBUG_REQUEST       0x07
 #define JTAG_INSTR_BYPASS              0x0F

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)