target/x86_32_common: change prototype of handle_iod_output()

To prepare for handling TCL return values consistently, all calls
to command_print/command_print_sameline should be ready to switch
to CMD as first parameter.

Change prototype of handle_iod_output() to pass CMD instead of
CMD_CTX.

This change was part of http://openocd.zylin.com/1815 from Paul
Fertser and has been extracted and rebased to simplify the review.

Change-Id: I67f594c80d6bbbbf6c9567069a545f16877b1e94
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5071
Tested-by: jenkins

diff --git a/src/target/x86_32_common.c b/src/target/x86_32_common.c
index 011e7d84377deff161f8371618b029b36c4131a4..a641ca94f7b5876513a7c2f0d8a2f1b0b1fdafcb 100644 (file)
--- a/src/target/x86_32_common.c
+++ b/src/target/x86_32_common.c
@@ -1340,7 +1340,7 @@ static int write_hw_reg_from_cache(struct target *t, int num)
 }
 
 /* x86 32 commands */
 }
 
 /* x86 32 commands */

-static void handle_iod_output(struct command_context *cmd_ctx,
+static void handle_iod_output(struct command_invocation *cmd,

                struct target *target, uint32_t address, unsigned size,
                unsigned count, const uint8_t *buffer)
 {
                struct target *target, uint32_t address, unsigned size,
                unsigned count, const uint8_t *buffer)
 {


@@ -1392,7 +1392,7 @@ static void handle_iod_output(struct command_context *cmd_ctx,
                                value_fmt, value);
 
                if ((i % line_modulo == line_modulo - 1) || (i == count - 1)) {
                                value_fmt, value);
 
                if ((i % line_modulo == line_modulo - 1) || (i == count - 1)) {

-                       command_print(cmd_ctx, "%s", output);
+                       command_print(cmd->ctx, "%s", output);

                        output_len = 0;
                }
        }
                        output_len = 0;
                }
        }


@@ -1429,7 +1429,7 @@ COMMAND_HANDLER(handle_iod_command)
        struct target *target = get_current_target(CMD_CTX);
        int retval = x86_32_common_read_io(target, address, size, buffer);
        if (ERROR_OK == retval)
        struct target *target = get_current_target(CMD_CTX);
        int retval = x86_32_common_read_io(target, address, size, buffer);
        if (ERROR_OK == retval)

-               handle_iod_output(CMD_CTX, target, address, size, count, buffer);
+               handle_iod_output(CMD, target, address, size, count, buffer);

        free(buffer);
        return retval;
 }
        free(buffer);
        return retval;
 }