jtag: fix opendous reset command
authorStefan Mahr <stefan.mahr@sphairon.com>
Wed, 27 Jun 2012 22:53:54 +0000 (00:53 +0200)
committerFreddie Chopin <freddie.chopin@gmail.com>
Wed, 11 Jul 2012 08:18:00 +0000 (08:18 +0000)
This cast to uint16_t is not (host) endianess save.
Depending on compiler usb_out_buffer[1] may be undefined.

Change-Id: If686e5d5da39541329c340bbdef472ee7ab0281c
Signed-off-by: Stefan Mahr <stefan.mahr@sphairon.com>
Reviewed-on: http://openocd.zylin.com/732
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>
src/jtag/drivers/opendous.c

index 0bb6da6..1b74bd5 100644 (file)
@@ -465,7 +465,8 @@ void opendous_simple_command(uint8_t command, uint8_t _data)
 
        DEBUG_JTAG_IO("0x%02x 0x%02x", command, _data);
 
-       usb_out_buffer[0] = (uint16_t) 2;
+       usb_out_buffer[0] = 2;
+       usb_out_buffer[1] = 0;
        usb_out_buffer[2] = command;
        usb_out_buffer[3] = _data;