helper/command: remove unused field in struct command_registration 25/5225/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Fri, 7 Jun 2019 13:31:06 +0000 (15:31 +0200)
committerTomas Vanek <vanekt@fbl.cz>
Thu, 19 Dec 2019 20:43:08 +0000 (20:43 +0000)
commit90bd7d148225efa587d8e62017625709a1ac002d
treea01d0a512fffd7ba7231a14d4798e04b509cf93e
parente8d4074cf859328990f14a6c57a669f741cb83a2
helper/command: remove unused field in struct command_registration

The field jim_handler_data in struct command_registration is never
assigned, thus has always value NULL. It was added in commit
17a9dea53a71 ("add jim_handler to command_registration") on Nov 23
2009, together with the homonym field jim_handler_data in struct
command, but never used since then.
Only the field jim_handler_data in struct command is used.

Remove the field from struct command_registration and use NULL
where it was referenced (or remove the assignment if the recipient
is already zero, e.g. allocated with calloc()).

Removing the field decreases the total size of OpenOCD binary by
only 4944 byte on a 64 bit x86. Not a significant improvement from
this point of view.

Change-Id: I9f1d281e3de6b2eb398e2d883c5e9ff92628aecd
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5225
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
src/helper/command.c
src/helper/command.h