coding style: remove useless break after a goto or return 17/5617/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Sun, 5 May 2019 22:03:03 +0000 (00:03 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 9 May 2020 13:39:05 +0000 (14:39 +0100)
commit9b29cb58acbd14ed831d68fce4d6e6a1728f8caf
tree76ba767e4074f82fb6ba90510086c2be9d5e00a4
parent5df5e89cf3caf02dc6f49a5d3c8aa8b1349a1dbf
coding style: remove useless break after a goto or return

In a switch/case statement, a break placed after a goto or return
is never executed.
The script checkpatch available in Linux kernel v5.1 issues a
warning for such unused break statements.
In the process of reviewing the new checkpatch for its inclusion
in OpenOCD, let's get rid of these warnings.

The script checkpatch is unable to fixup automatically this case.
Thanks to having "break" command using a single code line, this
patch has been generated using the script below:

find src/ -type f -exec ./tools/scripts/checkpatch.pl -q \
 --types UNNECESSARY_BREAK -f {} \; \
| sed -n '/^#/{s/^.*FILE: //;s/:$//;s/:/ /;p}' \
| awk 'function P() {print "sed -i '\''"b"'\'' "a};
       {
         if ($1!=a) {
           if (a) {P()};
           a=$1;
           b=$2"{d}";
         } else {
           b=b";"$2"{d}"
         }
       };
       END {P()}'

Change-Id: I56ca098faa5fe8d1e3f712dc0a029a3f10559d99
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5617
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Tested-by: jenkins
18 files changed:
src/flash/nand/mx3.c
src/flash/nand/mxc.c
src/flash/nor/aducm360.c
src/flash/nor/at91sam3.c
src/flash/nor/at91sam4.c
src/flash/nor/atsamv.c
src/flash/nor/cfi.c
src/flash/nor/psoc6.c
src/flash/nor/xcf.c
src/jtag/drivers/stlink_usb.c
src/jtag/drivers/ulink.c
src/svf/svf.c
src/target/arm_disassembler.c
src/target/arm_dpm.c
src/target/armv4_5.c
src/target/avr32_ap7k.c
src/target/riscv/riscv-013.c
src/transport/transport.c

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)