target, breakpoints: improve error handling 71/4871/4
authorTomas Vanek <vanekt@fbl.cz>
Thu, 24 Jan 2019 13:33:16 +0000 (14:33 +0100)
committerMatthias Welwarsky <matthias@welwarsky.de>
Fri, 15 Feb 2019 13:09:53 +0000 (13:09 +0000)
commitfd8a3c9516d6580ab749e4127f6dab0077a8b078
treea31ca7e80f3a9a50ce4cebf1e83d13eab5e6d90c
parent1c22f5b7dee61e6eb85159970c43240703a1a616
target, breakpoints: improve error handling

handle_bp_command_set() showed the error message
"Failure setting breakpoint, the same address(IVA) is already used"
on any error returned from (xxx_)breakpoint_add().
Paradoxically breakpoint_add() returned ERROR_OK if it detected
duplicated bp address.
context_breakpoint_add() and hybrid_breakpoint_add() returned -1
instead of OpenOCD compatible error if they detected duplicity.

Introduce ERROR_TARGET_DUPLICATE_BREAKPOINT
Unify error handling to LOG_ERROR() any error in (xxx_)breakpoint_add()
Remove misleading error messages from handle_bp_command_set()
handle_bp_command_set() returns error if the target does not implement
add_context_breakpoint or add_hybrid_breakpoint.

Change-Id: If17dfad1756d82a77028ebdc4b305f9c8e1365ba
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/4871
Tested-by: jenkins
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>
src/target/breakpoints.c
src/target/target.c
src/target/target.h