Tcl commands: Fix improper return status in flash commands and load_image. 31/2431/3
authorHarishKumar <harishpresent@gmail.com>
Tue, 9 Dec 2014 14:08:08 +0000 (19:38 +0530)
committerFreddie Chopin <freddie.chopin@gmail.com>
Fri, 4 Nov 2016 21:21:15 +0000 (21:21 +0000)
commitb10037a0b784cab94e21b37c976ad2b5174d52ae
treeb7ed728eec23d463a83aeb8c9fc9bfdfa572a74a
parentd3445cd146f8efa6f5bdbd636f51e247ec7de766
Tcl commands: Fix improper return status in flash commands and load_image.

Nand write command :
nand_fileio_cleanup() always returns ERROR_OK. Due to this,
handle_nand_write_command() retuns ERROR_OK in the case
of nand failure. ERROR_FAIL should be returned.

Flash erase_sector command :
handle_flash_erase_command() always returns ERROR_OK even if
the erase functionality of actual driver implementation fails.
retval value should be returned.

Flash write_bank command :
handle_flash_write_bank_command() returns ERROR_OK even if
fileio_open() and fileio_read fails. ERROR_FAIL should be
returned.

Load_image command :
handle_load_image_command() retuns ERROR_OK even if image_open()
fails. ERROR_FAIL should be returned.
When the buffer is null, breaking the loop without setting
retval = ERROR_FAIL would cause load_image to return ERROR_OK.

Change-Id: Ice32f6036971ab5e8e4dd65edf54b394b001c80c
Signed-off-by: HarishKumar <harishpresent@gmail.com>
Reviewed-on: http://openocd.zylin.com/2431
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Tested-by: jenkins
src/flash/nand/tcl.c
src/flash/nor/tcl.c
src/target/target.c