X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=src%2Ftarget%2Ftarget.c;h=376fc52f5ffd1d54182b33bbbe378e20ef0fdffc;hp=f1229d86f48857714e4719fdda3592852e9064c7;hb=5ed126c4f90948fbf53d186dc4ef49018fb5ecfc;hpb=3acb107b9ae4e3d38d3fcfd29b455ebcfb444696 diff --git a/src/target/target.c b/src/target/target.c index f1229d86f4..376fc52f5f 100644 --- a/src/target/target.c +++ b/src/target/target.c @@ -42,6 +42,8 @@ #include +#include + int cli_target_callback_event_handler(struct target_s *target, enum target_event event, void *priv); int handle_target_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); @@ -62,8 +64,8 @@ int handle_resume_command(struct command_context_s *cmd_ctx, char *cmd, char **a int handle_step_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); int handle_md_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); int handle_mw_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); -int handle_load_binary_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); -int handle_dump_binary_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); +int handle_load_image_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); +int handle_dump_image_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); int handle_bp_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); int handle_rbp_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); int handle_wp_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); @@ -76,6 +78,7 @@ extern target_type_t arm720t_target; extern target_type_t arm9tdmi_target; extern target_type_t arm920t_target; extern target_type_t arm966e_target; +extern target_type_t arm926ejs_target; target_type_t *target_types[] = { @@ -84,6 +87,7 @@ target_type_t *target_types[] = &arm920t_target, &arm720t_target, &arm966e_target, + &arm926ejs_target, NULL, }; @@ -209,6 +213,8 @@ int target_init_handler(struct target_s *target, enum target_event event, void * if ((event == TARGET_EVENT_HALTED) && (target->reset_script)) { + target_unregister_event_callback(target_init_handler, priv); + script = fopen(target->reset_script, "r"); if (!script) { @@ -221,8 +227,6 @@ int target_init_handler(struct target_s *target, enum target_event event, void * fclose(script); jtag_execute_queue(); - - target_unregister_event_callback(target_init_handler, priv); } return ERROR_OK; @@ -730,6 +734,8 @@ void target_read_u32(struct target_s *target, u32 address, u32 *value) target->type->read_memory(target, address, 4, 1, value_buf); *value = target_buffer_get_u32(target, value_buf); + + DEBUG("address: 0x%8.8x, value: 0x%8.8x", address, *value); } void target_read_u16(struct target_s *target, u32 address, u16 *value) @@ -739,17 +745,23 @@ void target_read_u16(struct target_s *target, u32 address, u16 *value) target->type->read_memory(target, address, 2, 1, value_buf); *value = target_buffer_get_u16(target, value_buf); + + DEBUG("address: 0x%8.8x, value: 0x%4.4x", address, *value); } void target_read_u8(struct target_s *target, u32 address, u8 *value) { target->type->read_memory(target, address, 1, 1, value); + + DEBUG("address: 0x%8.8x, value: 0x%2.2x", address, *value); } void target_write_u32(struct target_s *target, u32 address, u32 value) { u8 value_buf[4]; + DEBUG("address: 0x%8.8x, value: 0x%8.8x", address, value); + target_buffer_set_u32(target, value_buf, value); target->type->write_memory(target, address, 4, 1, value_buf); } @@ -758,12 +770,16 @@ void target_write_u16(struct target_s *target, u32 address, u16 value) { u8 value_buf[2]; + DEBUG("address: 0x%8.8x, value: 0x%8.8x", address, value); + target_buffer_set_u16(target, value_buf, value); target->type->write_memory(target, address, 2, 1, value_buf); } void target_write_u8(struct target_s *target, u32 address, u8 value) { + DEBUG("address: 0x%8.8x, value: 0x%2.2x", address, value); + target->type->read_memory(target, address, 1, 1, &value); } @@ -771,7 +787,7 @@ int target_register_user_commands(struct command_context_s *cmd_ctx) { register_command(cmd_ctx, NULL, "reg", handle_reg_command, COMMAND_EXEC, NULL); register_command(cmd_ctx, NULL, "poll", handle_poll_command, COMMAND_EXEC, "poll target state"); - register_command(cmd_ctx, NULL, "wait_halt", handle_wait_halt_command, COMMAND_EXEC, "wait for target halt"); + register_command(cmd_ctx, NULL, "wait_halt", handle_wait_halt_command, COMMAND_EXEC, "wait for target halt [time (s)]"); register_command(cmd_ctx, NULL, "halt", handle_halt_command, COMMAND_EXEC, "halt target"); register_command(cmd_ctx, NULL, "resume", handle_resume_command, COMMAND_EXEC, "resume target [addr]"); register_command(cmd_ctx, NULL, "step", handle_step_command, COMMAND_EXEC, "step one instruction"); @@ -791,8 +807,10 @@ int target_register_user_commands(struct command_context_s *cmd_ctx) register_command(cmd_ctx, NULL, "wp", handle_wp_command, COMMAND_EXEC, "set watchpoint
[value] [mask]"); register_command(cmd_ctx, NULL, "rwp", handle_rwp_command, COMMAND_EXEC, "remove watchpoint "); - register_command(cmd_ctx, NULL, "load_binary", handle_load_binary_command, COMMAND_EXEC, "load binary
"); - register_command(cmd_ctx, NULL, "dump_binary", handle_dump_binary_command, COMMAND_EXEC, "dump binary
"); + register_command(cmd_ctx, NULL, "load_image", handle_load_image_command, COMMAND_EXEC, "load_image
['bin'|'ihex']"); + register_command(cmd_ctx, NULL, "dump_image", handle_dump_image_command, COMMAND_EXEC, "dump_image
"); + register_command(cmd_ctx, NULL, "load_binary", handle_load_image_command, COMMAND_EXEC, "[DEPRECATED] load_binary
"); + register_command(cmd_ctx, NULL, "dump_binary", handle_dump_image_command, COMMAND_EXEC, "[DEPRECATED] dump_binary
"); return ERROR_OK; } @@ -904,7 +922,6 @@ int handle_target_command(struct command_context_s *cmd_ctx, char *cmd, char **a (*last_target_p)->working_areas = NULL; (*last_target_p)->backup_working_area = 0; - (*last_target_p)->endianness = TARGET_LITTLE_ENDIAN; (*last_target_p)->state = TARGET_UNKNOWN; (*last_target_p)->reg_cache = NULL; (*last_target_p)->breakpoints = NULL; @@ -1070,7 +1087,7 @@ int handle_reg_command(struct command_context_s *cmd_ctx, char *cmd, char **args int count = 0; char *value; - DEBUG(""); + DEBUG("-"); target = get_current_target(cmd_ctx); @@ -1085,7 +1102,7 @@ int handle_reg_command(struct command_context_s *cmd_ctx, char *cmd, char **args int i; for (i = 0; i < cache->num_regs; i++) { - value = buf_to_char(cache->reg_list[i].value, cache->reg_list[i].size); + value = buf_to_str(cache->reg_list[i].value, cache->reg_list[i].size, 16); command_print(cmd_ctx, "(%i) %s (/%i): 0x%s (dirty: %i, valid: %i)", count++, cache->reg_list[i].name, cache->reg_list[i].size, value, cache->reg_list[i].dirty, cache->reg_list[i].valid); free(value); } @@ -1150,7 +1167,7 @@ int handle_reg_command(struct command_context_s *cmd_ctx, char *cmd, char **args } arch_type->get(reg); } - value = buf_to_char(reg->value, reg->size); + value = buf_to_str(reg->value, reg->size, 16); command_print(cmd_ctx, "%s (/%i): 0x%s", reg->name, reg->size, value); free(value); return ERROR_OK; @@ -1159,7 +1176,9 @@ int handle_reg_command(struct command_context_s *cmd_ctx, char *cmd, char **args /* set register value */ if (argc == 2) { - u32 new_value = strtoul(args[1], NULL, 0); + u8 *buf = malloc(CEIL(reg->size, 8)); + str_to_buf(args[1], strlen(args[1]), buf, reg->size, 0); + reg_arch_type_t *arch_type = register_get_arch_type(reg->arch_type); if (arch_type == NULL) { @@ -1167,11 +1186,14 @@ int handle_reg_command(struct command_context_s *cmd_ctx, char *cmd, char **args return ERROR_OK; } - arch_type->set(reg, new_value); - value = buf_to_char(reg->value, reg->size); + arch_type->set(reg, buf); + + value = buf_to_str(reg->value, reg->size, 16); command_print(cmd_ctx, "%s (/%i): 0x%s", reg->name, reg->size, value); free(value); + free(buf); + return ERROR_OK; } @@ -1217,7 +1239,17 @@ int handle_wait_halt_command(struct command_context_s *cmd_ctx, char *cmd, char struct timeval timeout, now; gettimeofday(&timeout, NULL); - timeval_add_time(&timeout, 5, 0); + if (!argc) + timeval_add_time(&timeout, 5, 0); + else { + char *end; + + timeval_add_time(&timeout, strtoul(args[0], &end, 0), 0); + if (*end) { + command_print(cmd_ctx, "usage: wait_halt [seconds]"); + return ERROR_OK; + } + } command_print(cmd_ctx, "waiting for target halted..."); @@ -1247,7 +1279,7 @@ int handle_halt_command(struct command_context_s *cmd_ctx, char *cmd, char **arg int retval; target_t *target = get_current_target(cmd_ctx); - DEBUG(""); + DEBUG("-"); command_print(cmd_ctx, "requesting target halt..."); @@ -1321,7 +1353,7 @@ int handle_reset_command(struct command_context_s *cmd_ctx, char *cmd, char **ar target_t *target = get_current_target(cmd_ctx); enum target_reset_mode reset_mode = RESET_RUN; - DEBUG(""); + DEBUG("-"); if (argc >= 1) { @@ -1365,7 +1397,7 @@ int handle_resume_command(struct command_context_s *cmd_ctx, char *cmd, char **a int retval; target_t *target = get_current_target(cmd_ctx); - DEBUG(""); + DEBUG("-"); if (argc == 0) retval = target->type->resume(target, 1, 0, 1, 0); /* current pc, addr = 0, handle breakpoints, not debugging */ @@ -1397,7 +1429,7 @@ int handle_step_command(struct command_context_s *cmd_ctx, char *cmd, char **arg { target_t *target = get_current_target(cmd_ctx); - DEBUG(""); + DEBUG("-"); if (argc == 0) target->type->step(target, 1, 0, 1); /* current pc, addr = 0, handle breakpoints */ @@ -1554,118 +1586,126 @@ int handle_mw_command(struct command_context_s *cmd_ctx, char *cmd, char **args, } -int handle_load_binary_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc) +int handle_load_image_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc) { - FILE *binary; u32 address; - struct stat binary_stat; - u32 binary_size; - u8 *buffer; u32 buf_cnt; + u32 binary_size; + + fileio_t file; + enum fileio_pri_type pri_type = FILEIO_IMAGE; + fileio_image_t image_info; + enum fileio_sec_type sec_type; + + duration_t duration; + char *duration_text; - struct timeval start, end, duration; - target_t *target = get_current_target(cmd_ctx); - if (argc != 2) + if (argc < 2) { - command_print(cmd_ctx, "usage: load_binary
"); + command_print(cmd_ctx, "usage: load_image
[type]"); return ERROR_OK; } + + memset(&file, 0, sizeof(fileio_t)); + fileio_identify_image_type(&sec_type, (argc == 3) ? args[2] : NULL); - address = strtoul(args[1], NULL, 0); - - if (stat(args[0], &binary_stat) == -1) - { - ERROR("couldn't stat() %s: %s", args[0], strerror(errno)); - command_print(cmd_ctx, "error accessing file %s", args[0]); - return ERROR_OK; - } + image_info.base_address = strtoul(args[1], NULL, 0); + image_info.has_start_address = 0; + + buffer = malloc(128 * 1024); - if (!(binary = fopen(args[0], "rb"))) + duration_start_measure(&duration); + + if (fileio_open(&file, args[0], FILEIO_READ, + pri_type, &image_info, sec_type) != ERROR_OK) { - ERROR("couldn't open %s: %s", args[0], strerror(errno)); - command_print(cmd_ctx, "error accessing file %s", args[0]); + command_print(cmd_ctx, "load_image error: %s", file.error_str); return ERROR_OK; } - buffer = malloc(128 * 1024); - - gettimeofday(&start, NULL); - - binary_size = binary_stat.st_size; - while (binary_size > 0) + binary_size = file.size; + address = image_info.base_address; + while ((binary_size > 0) && + (fileio_read(&file, 128 * 1024, buffer, &buf_cnt) == ERROR_OK)) { - buf_cnt = fread(buffer, 1, 128*1024, binary); target_write_buffer(target, address, buf_cnt, buffer); address += buf_cnt; binary_size -= buf_cnt; } - gettimeofday(&end, NULL); - free(buffer); - timeval_subtract(&duration, &end, &start); - command_print(cmd_ctx, "downloaded %lli byte in %is %ius", (long long) binary_stat.st_size, duration.tv_sec, duration.tv_usec); + duration_stop_measure(&duration, &duration_text); + command_print(cmd_ctx, "downloaded %lli byte in %s", file.size, duration_text); + free(duration_text); - fclose(binary); + fileio_close(&file); return ERROR_OK; } -int handle_dump_binary_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc) +int handle_dump_image_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc) { - FILE *binary; + fileio_t file; + fileio_image_t image_info; + u32 address; u32 size; u8 buffer[560]; - struct timeval start, end, duration; + duration_t duration; + char *duration_text; target_t *target = get_current_target(cmd_ctx); if (argc != 3) { - command_print(cmd_ctx, "usage: dump_binary
"); + command_print(cmd_ctx, "usage: dump_image
"); return ERROR_OK; } address = strtoul(args[1], NULL, 0); size = strtoul(args[2], NULL, 0); - if (!(binary = fopen(args[0], "wb"))) + if ((address & 3) || (size & 3)) { - ERROR("couldn't open %s for writing: %s", args[0], strerror(errno)); - command_print(cmd_ctx, "error accessing file %s", args[0]); + command_print(cmd_ctx, "only 32-bit aligned address and size are supported"); return ERROR_OK; } - - if ((address & 3) || (size & 3)) + + image_info.base_address = address; + image_info.has_start_address = 0; + + if (fileio_open(&file, args[0], FILEIO_WRITE, + FILEIO_IMAGE, &image_info, FILEIO_PLAIN) != ERROR_OK) { - command_print(cmd_ctx, "only 32-bit aligned address and size are supported"); + command_print(cmd_ctx, "dump_image error: %s", file.error_str); return ERROR_OK; } - - gettimeofday(&start, NULL); + + duration_start_measure(&duration); while (size > 0) { + u32 size_written; u32 this_run_size = (size > 560) ? 560 : size; + target->type->read_memory(target, address, 4, this_run_size / 4, buffer); - fwrite(buffer, 1, this_run_size, binary); + fileio_write(&file, this_run_size, buffer, &size_written); + size -= this_run_size; address += this_run_size; } - fclose(binary); - - gettimeofday(&end, NULL); + fileio_close(&file); - timeval_subtract(&duration, &end, &start); - command_print(cmd_ctx, "dumped %i byte in %is %ius", strtoul(args[2], NULL, 0), duration.tv_sec, duration.tv_usec); + duration_stop_measure(&duration, &duration_text); + command_print(cmd_ctx, "dumped %lli byte in %s", file.size, duration_text); + free(duration_text); return ERROR_OK; @@ -1684,7 +1724,7 @@ int handle_bp_command(struct command_context_s *cmd_ctx, char *cmd, char **args, { if (breakpoint->type == BKPT_SOFT) { - char* buf = buf_to_char(breakpoint->orig_instr, breakpoint->length); + char* buf = buf_to_str(breakpoint->orig_instr, breakpoint->length, 16); command_print(cmd_ctx, "0x%8.8x, 0x%x, %i, 0x%s", breakpoint->address, breakpoint->length, breakpoint->set, buf); free(buf); }