X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=src%2Ftarget%2Fregister.c;h=355c860121372c45c6cd6a3d9420fd90d0d606c8;hp=c3ad830a55151f123e3eb6183dc9098333c6d0fe;hb=b48d1f66378fac886d5bc32d7302da48c89d8a75;hpb=c2b5d8a6fa72ce6b0fed1e612d4fe5e4b54ba45a

diff --git a/src/target/register.c b/src/target/register.c
index c3ad830a55..355c860121 100644
--- a/src/target/register.c
+++ b/src/target/register.c
@@ -24,16 +24,24 @@
 #include "config.h"
 #endif
 
+#include <helper/types.h>
 #include "register.h"
-#include "log.h"
-
-
-struct reg_arch_type *reg_arch_types = NULL;
-
-reg_t* register_get_by_name(struct reg_cache *first,
+#include <helper/log.h>
+
+/**
+ * @file
+ * Holds utilities to work with register caches.
+ *
+ * OpenOCD uses machine registers internally, and exposes them by name
+ * to Tcl scripts.  Sets of related registers are grouped into caches.
+ * For example, a CPU core will expose a set of registers, and there
+ * may be separate registers associated with debug or trace modules.
+ */
+
+struct reg* register_get_by_name(struct reg_cache *first,
 		const char *name, bool search_all)
 {
-	int i;
+	unsigned i;
 	struct reg_cache *cache = first;
 
 	while (cache)
@@ -66,50 +74,23 @@ struct reg_cache** register_get_last_cache_p(struct reg_cache **first)
 	return cache_p;
 }
 
-int register_reg_arch_type(int (*get)(reg_t *reg), int (*set)(reg_t *reg, uint8_t *buf))
+/** Marks the contents of the register cache as invalid (and clean). */
+void register_cache_invalidate(struct reg_cache *cache)
 {
-	struct reg_arch_type** arch_type_p = &reg_arch_types;
-	int id = 0;
+	struct reg *reg = cache->reg_list;
 
-	if (*arch_type_p)
-	{
-		while (*arch_type_p)
-		{
-			id = (*arch_type_p)->id;
-			arch_type_p = &((*arch_type_p)->next);
-		}
+	for (unsigned n = cache->num_regs; n != 0; n--, reg++) {
+		reg->valid = 0;
+		reg->dirty = 0;
 	}
-
-	(*arch_type_p) = malloc(sizeof(struct reg_arch_type));
-	(*arch_type_p)->id = id + 1;
-	(*arch_type_p)->set = set;
-	(*arch_type_p)->get = get;
-	(*arch_type_p)->next = NULL;
-
-	return id + 1;
 }
 
-struct reg_arch_type* register_get_arch_type(int id)
-{
-	struct reg_arch_type *arch_type = reg_arch_types;
-
-	while (arch_type)
-	{
-		if (arch_type->id == id)
-			return arch_type;
-		arch_type = arch_type->next;
-	}
-	LOG_ERROR("BUG: encountered unregistered arch type 0x%08x", id);
-	exit(-1);
-	return NULL;
-}
-
-static int register_get_dummy_core_reg(reg_t *reg)
+static int register_get_dummy_core_reg(struct reg *reg)
 {
 	return ERROR_OK;
 }
 
-static int register_set_dummy_core_reg(reg_t *reg, uint8_t *buf)
+static int register_set_dummy_core_reg(struct reg *reg, uint8_t *buf)
 {
 	reg->dirty = 1;
 	reg->valid = 1;
@@ -117,11 +98,12 @@ static int register_set_dummy_core_reg(reg_t *reg, uint8_t *buf)
 	return ERROR_OK;
 }
 
-void register_init_dummy(reg_t *reg)
-{
-	static int dummy_arch_type = -1;
-	if (dummy_arch_type == -1)
-		dummy_arch_type = register_reg_arch_type(register_get_dummy_core_reg, register_set_dummy_core_reg);
+static const struct reg_arch_type dummy_type = {
+	.get = register_get_dummy_core_reg,
+	.set = register_set_dummy_core_reg,
+};
 
-	reg->arch_type = dummy_arch_type;
+void register_init_dummy(struct reg *reg)
+{
+	reg->type = &dummy_type;
 }