X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=src%2Ftarget%2Fetb.c;h=b96ffe318af2e5b000c8284843b5924c6f2dee3f;hp=05d970d53d699a9bda62953c7edfdaa81857eeff;hb=8c1ec4f0e1a7dd37a2549d83b6cd5c8c57eb34aa;hpb=e3462b228ce9533b6e7989361f9c4090043a8aa4 diff --git a/src/target/etb.c b/src/target/etb.c index 05d970d53d..b96ffe318a 100644 --- a/src/target/etb.c +++ b/src/target/etb.c @@ -36,7 +36,7 @@ #include -char* etb_reg_list[] = +static char* etb_reg_list[] = { "ETB_identification", "ETB_ram_depth", @@ -49,29 +49,25 @@ char* etb_reg_list[] = "ETB_control", }; -int etb_reg_arch_type = -1; +static int etb_reg_arch_type = -1; -int etb_get_reg(reg_t *reg); -int etb_set_reg(reg_t *reg, u32 value); -int etb_set_reg_w_exec(reg_t *reg, u8 *buf); +static int etb_get_reg(reg_t *reg); -int etb_write_reg(reg_t *reg, u32 value); -int etb_read_reg(reg_t *reg); +static int handle_etb_config_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); -int handle_etb_config_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc); - -int etb_set_instr(etb_t *etb, u32 new_instr) +static int etb_set_instr(etb_t *etb, u32 new_instr) { - jtag_device_t *device = jtag_get_device(etb->chain_pos); - if (device==NULL) + jtag_tap_t *tap; + tap = etb->tap; + if (tap==NULL) return ERROR_FAIL; - if (buf_get_u32(device->cur_instr, 0, device->ir_length) != new_instr) + if (buf_get_u32(tap->cur_instr, 0, tap->ir_length) != new_instr) { scan_field_t field; - field.device = etb->chain_pos; - field.num_bits = device->ir_length; + field.tap = tap; + field.num_bits = tap->ir_length; field.out_value = calloc(CEIL(field.num_bits, 8), 1); buf_set_u32(field.out_value, 0, field.num_bits, new_instr); field.out_mask = NULL; @@ -81,7 +77,7 @@ int etb_set_instr(etb_t *etb, u32 new_instr) field.in_handler = NULL; field.in_handler_priv = NULL; - jtag_add_ir_scan(1, &field, -1); + jtag_add_ir_scan(1, &field, TAP_INVALID); free(field.out_value); } @@ -89,13 +85,13 @@ int etb_set_instr(etb_t *etb, u32 new_instr) return ERROR_OK; } -int etb_scann(etb_t *etb, u32 new_scan_chain) +static int etb_scann(etb_t *etb, u32 new_scan_chain) { if(etb->cur_scan_chain != new_scan_chain) { scan_field_t field; - field.device = etb->chain_pos; + field.tap = etb->tap; field.num_bits = 5; field.out_value = calloc(CEIL(field.num_bits, 8), 1); buf_set_u32(field.out_value, 0, field.num_bits, new_scan_chain); @@ -108,7 +104,7 @@ int etb_scann(etb_t *etb, u32 new_scan_chain) /* select INTEST instruction */ etb_set_instr(etb, 0x2); - jtag_add_dr_scan(1, &field, -1); + jtag_add_dr_scan(1, &field, TAP_INVALID); etb->cur_scan_chain = new_scan_chain; @@ -160,7 +156,7 @@ reg_cache_t* etb_build_reg_cache(etb_t *etb) return reg_cache; } -int etb_get_reg(reg_t *reg) +static int etb_get_reg(reg_t *reg) { int retval; if ((retval = etb_read_reg(reg)) != ERROR_OK) @@ -178,16 +174,16 @@ int etb_get_reg(reg_t *reg) return ERROR_OK; } -int etb_read_ram(etb_t *etb, u32 *data, int num_frames) +static int etb_read_ram(etb_t *etb, u32 *data, int num_frames) { scan_field_t fields[3]; int i; - jtag_add_end_state(TAP_RTI); + jtag_add_end_state(TAP_IDLE); etb_scann(etb, 0x0); etb_set_instr(etb, 0xc); - fields[0].device = etb->chain_pos; + fields[0].tap = etb->tap; fields[0].num_bits = 32; fields[0].out_value = NULL; fields[0].out_mask = NULL; @@ -197,7 +193,7 @@ int etb_read_ram(etb_t *etb, u32 *data, int num_frames) fields[0].in_handler = NULL; fields[0].in_handler_priv = NULL; - fields[1].device = etb->chain_pos; + fields[1].tap = etb->tap; fields[1].num_bits = 7; fields[1].out_value = malloc(1); buf_set_u32(fields[1].out_value, 0, 7, 4); @@ -208,7 +204,7 @@ int etb_read_ram(etb_t *etb, u32 *data, int num_frames) fields[1].in_handler = NULL; fields[1].in_handler_priv = NULL; - fields[2].device = etb->chain_pos; + fields[2].tap = etb->tap; fields[2].num_bits = 1; fields[2].out_value = malloc(1); buf_set_u32(fields[2].out_value, 0, 1, 0); @@ -219,7 +215,7 @@ int etb_read_ram(etb_t *etb, u32 *data, int num_frames) fields[2].in_handler = NULL; fields[2].in_handler_priv = NULL; - jtag_add_dr_scan(3, fields, -1); + jtag_add_dr_scan(3, fields, TAP_INVALID); fields[0].in_handler = buf_to_u32_handler; @@ -235,7 +231,7 @@ int etb_read_ram(etb_t *etb, u32 *data, int num_frames) buf_set_u32(fields[1].out_value, 0, 7, 0); fields[0].in_handler_priv = &data[i]; - jtag_add_dr_scan(3, fields, -1); + jtag_add_dr_scan(3, fields, TAP_INVALID); } jtag_execute_queue(); @@ -254,11 +250,11 @@ int etb_read_reg_w_check(reg_t *reg, u8* check_value, u8* check_mask) LOG_DEBUG("%i", etb_reg->addr); - jtag_add_end_state(TAP_RTI); + jtag_add_end_state(TAP_IDLE); etb_scann(etb_reg->etb, 0x0); etb_set_instr(etb_reg->etb, 0xc); - fields[0].device = etb_reg->etb->chain_pos; + fields[0].tap = etb_reg->etb->tap; fields[0].num_bits = 32; fields[0].out_value = reg->value; fields[0].out_mask = NULL; @@ -268,7 +264,7 @@ int etb_read_reg_w_check(reg_t *reg, u8* check_value, u8* check_mask) fields[0].in_handler = NULL; fields[0].in_handler_priv = NULL; - fields[1].device = etb_reg->etb->chain_pos; + fields[1].tap = etb_reg->etb->tap; fields[1].num_bits = 7; fields[1].out_value = malloc(1); buf_set_u32(fields[1].out_value, 0, 7, reg_addr); @@ -279,7 +275,7 @@ int etb_read_reg_w_check(reg_t *reg, u8* check_value, u8* check_mask) fields[1].in_handler = NULL; fields[1].in_handler_priv = NULL; - fields[2].device = etb_reg->etb->chain_pos; + fields[2].tap = etb_reg->etb->tap; fields[2].num_bits = 1; fields[2].out_value = malloc(1); buf_set_u32(fields[2].out_value, 0, 1, 0); @@ -290,7 +286,7 @@ int etb_read_reg_w_check(reg_t *reg, u8* check_value, u8* check_mask) fields[2].in_handler = NULL; fields[2].in_handler_priv = NULL; - jtag_add_dr_scan(3, fields, -1); + jtag_add_dr_scan(3, fields, TAP_INVALID); /* read the identification register in the second run, to make sure we * don't read the ETB data register twice, skipping every second entry @@ -300,7 +296,7 @@ int etb_read_reg_w_check(reg_t *reg, u8* check_value, u8* check_mask) jtag_set_check_value(fields+0, check_value, check_mask, NULL); - jtag_add_dr_scan(3, fields, -1); + jtag_add_dr_scan(3, fields, TAP_INVALID); free(fields[1].out_value); free(fields[2].out_value); @@ -350,11 +346,11 @@ int etb_write_reg(reg_t *reg, u32 value) LOG_DEBUG("%i: 0x%8.8x", etb_reg->addr, value); - jtag_add_end_state(TAP_RTI); + jtag_add_end_state(TAP_IDLE); etb_scann(etb_reg->etb, 0x0); etb_set_instr(etb_reg->etb, 0xc); - fields[0].device = etb_reg->etb->chain_pos; + fields[0].tap = etb_reg->etb->tap; fields[0].num_bits = 32; fields[0].out_value = malloc(4); buf_set_u32(fields[0].out_value, 0, 32, value); @@ -365,7 +361,7 @@ int etb_write_reg(reg_t *reg, u32 value) fields[0].in_handler = NULL; fields[0].in_handler_priv = NULL; - fields[1].device = etb_reg->etb->chain_pos; + fields[1].tap = etb_reg->etb->tap; fields[1].num_bits = 7; fields[1].out_value = malloc(1); buf_set_u32(fields[1].out_value, 0, 7, reg_addr); @@ -376,7 +372,7 @@ int etb_write_reg(reg_t *reg, u32 value) fields[1].in_handler = NULL; fields[1].in_handler_priv = NULL; - fields[2].device = etb_reg->etb->chain_pos; + fields[2].tap = etb_reg->etb->tap; fields[2].num_bits = 1; fields[2].out_value = malloc(1); buf_set_u32(fields[2].out_value, 0, 1, 1); @@ -387,7 +383,7 @@ int etb_write_reg(reg_t *reg, u32 value) fields[2].in_handler = NULL; fields[2].in_handler_priv = NULL; - jtag_add_dr_scan(3, fields, -1); + jtag_add_dr_scan(3, fields, TAP_INVALID); free(fields[0].out_value); free(fields[1].out_value); @@ -401,7 +397,7 @@ int etb_store_reg(reg_t *reg) return etb_write_reg(reg, buf_get_u32(reg->value, 0, reg->size)); } -int etb_register_commands(struct command_context_s *cmd_ctx) +static int etb_register_commands(struct command_context_s *cmd_ctx) { command_t *etb_cmd; @@ -412,10 +408,10 @@ int etb_register_commands(struct command_context_s *cmd_ctx) return ERROR_OK; } -int handle_etb_config_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc) +static int handle_etb_config_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc) { target_t *target; - jtag_device_t *jtag_device; + jtag_tap_t *tap; armv4_5_common_t *armv4_5; arm7_9_common_t *arm7_9; @@ -438,21 +434,21 @@ int handle_etb_config_command(struct command_context_s *cmd_ctx, char *cmd, char return ERROR_FAIL; } - jtag_device = jtag_get_device(strtoul(args[1], NULL, 0)); - - if (!jtag_device) - { + tap = jtag_TapByString( args[1] ); + if( tap == NULL ){ + command_print(cmd_ctx, "Tap: %s does not exist", args[1] ); return ERROR_FAIL; } + if (arm7_9->etm_ctx) { etb_t *etb = malloc(sizeof(etb_t)); arm7_9->etm_ctx->capture_driver_priv = etb; - etb->chain_pos = strtoul(args[1], NULL, 0); - etb->cur_scan_chain = -1; + etb->tap = tap; + etb->cur_scan_chain = ~0UL; etb->reg_cache = NULL; etb->ram_width = 0; etb->ram_depth = 0; @@ -466,7 +462,7 @@ int handle_etb_config_command(struct command_context_s *cmd_ctx, char *cmd, char return ERROR_OK; } -int etb_init(etm_context_t *etm_ctx) +static int etb_init(etm_context_t *etm_ctx) { etb_t *etb = etm_ctx->capture_driver_priv; @@ -483,7 +479,7 @@ int etb_init(etm_context_t *etm_ctx) return ERROR_OK; } -trace_status_t etb_status(etm_context_t *etm_ctx) +static trace_status_t etb_status(etm_context_t *etm_ctx) { etb_t *etb = etm_ctx->capture_driver_priv; @@ -538,7 +534,7 @@ trace_status_t etb_status(etm_context_t *etm_ctx) return etm_ctx->capture_status; } -int etb_read_trace(etm_context_t *etm_ctx) +static int etb_read_trace(etm_context_t *etm_ctx) { etb_t *etb = etm_ctx->capture_driver_priv; int first_frame = 0; @@ -688,7 +684,7 @@ int etb_read_trace(etm_context_t *etm_ctx) return ERROR_OK; } -int etb_start_capture(etm_context_t *etm_ctx) +static int etb_start_capture(etm_context_t *etm_ctx) { etb_t *etb = etm_ctx->capture_driver_priv; u32 etb_ctrl_value = 0x1; @@ -720,7 +716,7 @@ int etb_start_capture(etm_context_t *etm_ctx) return ERROR_OK; } -int etb_stop_capture(etm_context_t *etm_ctx) +static int etb_stop_capture(etm_context_t *etm_ctx) { etb_t *etb = etm_ctx->capture_driver_priv; reg_t *etb_ctrl_reg = &etb->reg_cache->reg_list[ETB_CTRL];