X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=src%2Fsvf%2Fsvf.c;h=223af7e182bbe3693fa18c857b780fcb7326ea57;hp=0d37c8ff59dc819c78c840f213f6c6b60f7dcf3d;hb=8b192df59a10df105af3cff1551f5181deea83d6;hpb=dd4e3a2406f97e19487aaaecbaaa3c542169e7af
diff --git a/src/svf/svf.c b/src/svf/svf.c
index 0d37c8ff59..223af7e182 100644
--- a/src/svf/svf.c
+++ b/src/svf/svf.c
@@ -13,9 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License *
- * along with this program; if not, write to the *
- * Free Software Foundation, Inc., *
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. *
+ * along with this program. If not, see . *
***************************************************************************/
/* The specification for SVF is available here:
@@ -216,13 +214,14 @@ static int svf_read_command_from_file(FILE *fd);
static int svf_check_tdo(void);
static int svf_add_check_para(uint8_t enabled, int buffer_offset, int bit_len);
static int svf_run_command(struct command_context *cmd_ctx, char *cmd_str);
+static int svf_execute_tap(void);
static FILE *svf_fd;
static char *svf_read_line;
static size_t svf_read_line_size;
static char *svf_command_buffer;
static size_t svf_command_buffer_size;
-static int svf_line_number = 1;
+static int svf_line_number;
static int svf_getline(char **lineptr, size_t *n, FILE *stream);
#define SVF_MAX_BUFFER_SIZE_TO_COMMIT (1024 * 1024)
@@ -230,6 +229,7 @@ static uint8_t *svf_tdi_buffer, *svf_tdo_buffer, *svf_mask_buffer;
static int svf_buffer_index, svf_buffer_size ;
static int svf_quiet;
static int svf_nil;
+static int svf_ignore_error;
/* Targetting particular tap */
static int svf_tap_is_specified;
@@ -257,7 +257,7 @@ static void svf_hexbuf_print(int dbg_lvl, const char *file, unsigned line,
int msbits = bit_len % 8;
/* allocate 2 bytes per hex digit */
- char *prbuf = malloc((byte_len * 2) + 1);
+ char *prbuf = malloc((byte_len * 2) + 2 + 1);
if (!prbuf)
return;
@@ -276,6 +276,9 @@ static int svf_realloc_buffers(size_t len)
{
void *ptr;
+ if (svf_execute_tap() != ERROR_OK)
+ return ERROR_FAIL;
+
ptr = realloc(svf_tdi_buffer, len);
if (!ptr)
return ERROR_FAIL;
@@ -358,7 +361,7 @@ COMMAND_HANDLER(handle_svf_command)
#define SVF_MAX_NUM_OF_OPTIONS 5
int command_num = 0;
int ret = ERROR_OK;
- long long time_measure_ms;
+ int64_t time_measure_ms;
int time_measure_s, time_measure_m;
/* use NULL to indicate a "plain" svf file which accounts for
@@ -373,6 +376,8 @@ COMMAND_HANDLER(handle_svf_command)
/* parse command line */
svf_quiet = 0;
svf_nil = 0;
+ svf_progress_enabled = 0;
+ svf_ignore_error = 0;
for (unsigned int i = 0; i < CMD_ARGC; i++) {
if (strcmp(CMD_ARGV[i], "-tap") == 0) {
tap = jtag_tap_by_string(CMD_ARGV[i+1]);
@@ -389,6 +394,9 @@ COMMAND_HANDLER(handle_svf_command)
else if ((strcmp(CMD_ARGV[i],
"progress") == 0) || (strcmp(CMD_ARGV[i], "-progress") == 0))
svf_progress_enabled = 1;
+ else if ((strcmp(CMD_ARGV[i],
+ "ignore_error") == 0) || (strcmp(CMD_ARGV[i], "-ignore_error") == 0))
+ svf_ignore_error = 1;
else {
svf_fd = fopen(CMD_ARGV[i], "r");
if (svf_fd == NULL) {
@@ -408,7 +416,7 @@ COMMAND_HANDLER(handle_svf_command)
time_measure_ms = timeval_ms();
/* init */
- svf_line_number = 1;
+ svf_line_number = 0;
svf_command_buffer_size = 0;
svf_check_tdo_para_index = 0;
@@ -527,7 +535,7 @@ COMMAND_HANDLER(handle_svf_command)
time_measure_s %= 60;
if (time_measure_ms < 1000)
command_print(CMD_CTX,
- "\r\nTime used: %dm%ds%lldms ",
+ "\r\nTime used: %dm%ds%" PRId64 "ms ",
time_measure_m,
time_measure_s,
time_measure_ms);
@@ -572,11 +580,14 @@ free_all:
if (ERROR_OK == ret)
command_print(CMD_CTX,
- "svf file programmed successfully for %d commands",
- command_num);
+ "svf file programmed %s for %d commands with %d errors",
+ (svf_ignore_error > 1) ? "unsuccessfully" : "successfully",
+ command_num,
+ (svf_ignore_error > 1) ? (svf_ignore_error - 1) : 0);
else
command_print(CMD_CTX, "svf file programmed failed");
+ svf_ignore_error = 0;
return ret;
}
@@ -650,11 +661,13 @@ static int svf_read_command_from_file(FILE *fd)
if (svf_getline(&svf_read_line, &svf_read_line_size, svf_fd) <= 0)
return ERROR_FAIL;
i = -1;
+ /* fallthrough */
case '\r':
slash = 0;
/* Don't save '\r' and '\n' if no data is parsed */
if (!cmd_pos)
break;
+ /* fallthrough */
default:
/* The parsing code currently expects a space
* before parentheses -- "TDI (123)". Also a
@@ -728,6 +741,9 @@ parse_char:
pos++;
}
+ if (num == 0)
+ return ERROR_FAIL;
+
*num_of_argu = num;
return ERROR_OK;
@@ -860,7 +876,11 @@ static int svf_check_tdo(void)
SVF_BUF_LOG(ERROR, &svf_tdi_buffer[index_var], len, "READ");
SVF_BUF_LOG(ERROR, &svf_tdo_buffer[index_var], len, "WANT");
SVF_BUF_LOG(ERROR, &svf_mask_buffer[index_var], len, "MASK");
- return ERROR_FAIL;
+
+ if (svf_ignore_error == 0)
+ return ERROR_FAIL;
+ else
+ svf_ignore_error++;
}
}
svf_check_tdo_para_index = 0;
@@ -1018,6 +1038,19 @@ XXR_common:
}
i_tmp = xxr_para_tmp->len;
xxr_para_tmp->len = atoi(argus[1]);
+ /* If we are to enlarge the buffers, all parts of xxr_para_tmp
+ * need to be freed */
+ if (i_tmp < xxr_para_tmp->len) {
+ free(xxr_para_tmp->tdi);
+ xxr_para_tmp->tdi = NULL;
+ free(xxr_para_tmp->tdo);
+ xxr_para_tmp->tdo = NULL;
+ free(xxr_para_tmp->mask);
+ xxr_para_tmp->mask = NULL;
+ free(xxr_para_tmp->smask);
+ xxr_para_tmp->smask = NULL;
+ }
+
LOG_DEBUG("\tlength = %d", xxr_para_tmp->len);
xxr_para_tmp->data_mask = 0;
for (i = 2; i < num_of_argu; i += 2) {
@@ -1283,7 +1316,7 @@ XXR_common:
* SEC]] [ENDSTATE end_state] */
/* RUNTEST [run_state] min_time SEC [MAXIMUM max_time SEC] [ENDSTATE
* end_state] */
- if ((num_of_argu < 3) && (num_of_argu > 11)) {
+ if ((num_of_argu < 3) || (num_of_argu > 11)) {
LOG_ERROR("invalid parameter of %s", argus[0]);
return ERROR_FAIL;
}
@@ -1539,7 +1572,7 @@ static const struct command_registration svf_command_handlers[] = {
.handler = handle_svf_command,
.mode = COMMAND_EXEC,
.help = "Runs a SVF file.",
- .usage = "svf [-tap device.tap] [quiet] [nil] [progress]",
+ .usage = "svf [-tap device.tap] [quiet] [nil] [progress] [ignore_error]",
},
COMMAND_REGISTRATION_DONE
};