X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=src%2Fopenocd.c;h=b5bb44b33c0eebed2c6199f78bc531d82d5b5ad3;hp=60cbf232a61d1c8e68f006a2d5c3dc2606791149;hb=d0e763ac7ef6aa17b17bd00ccdfbccfb4eacda69;hpb=54d6330b78f46678e78d1ffb265c65fcc8991e83

diff --git a/src/openocd.c b/src/openocd.c
index 60cbf232a6..b5bb44b33c 100644
--- a/src/openocd.c
+++ b/src/openocd.c
@@ -19,9 +19,7 @@
  *   GNU General Public License for more details.                          *
  *                                                                         *
  *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
+ *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
@@ -47,38 +45,40 @@
 #include <strings.h>
 #endif
 
-#define OPENOCD_VERSION \
-		"Open On-Chip Debugger " VERSION RELSTR " (" PKGBLDDATE ")"
+#define OPENOCD_VERSION	\
+	"Open On-Chip Debugger " VERSION RELSTR " (" PKGBLDDATE ")"
+
+static const char openocd_startup_tcl[] = {
+#include "startup_tcl.inc"
+0 /* Terminate with zero */
+};
 
 /* Give scripts and TELNET a way to find out what version this is */
 static int jim_version_command(Jim_Interp *interp, int argc,
-		Jim_Obj * const *argv)
+	Jim_Obj * const *argv)
 {
 	if (argc > 2)
-	{
 		return JIM_ERR;
-	}
 	const char *str = "";
-	char * version_str;
+	char *version_str;
 	version_str = OPENOCD_VERSION;
 
 	if (argc == 2)
 		str = Jim_GetString(argv[1], NULL);
 
 	if (strcmp("git", str) == 0)
-	{
 		version_str = GITVERSION;
-	}
 
 	Jim_SetResult(interp, Jim_NewStringObj(interp, version_str, -1));
 
 	return JIM_OK;
 }
 
-static int log_target_callback_event_handler(struct target *target, enum target_event event, void *priv)
+static int log_target_callback_event_handler(struct target *target,
+	enum target_event event,
+	void *priv)
 {
-	switch (event)
-	{
+	switch (event) {
 		case TARGET_EVENT_GDB_START:
 			target->display = 0;
 			break;
@@ -86,8 +86,7 @@ static int log_target_callback_event_handler(struct target *target, enum target_
 			target->display = 1;
 			break;
 		case TARGET_EVENT_HALTED:
-			if (target->display)
-			{
+			if (target->display) {
 				/* do not display information when debugger caused the halt */
 				target_arch_state(target);
 			}
@@ -117,7 +116,7 @@ COMMAND_HANDLER(handle_init_command)
 		return ERROR_COMMAND_SYNTAX_ERROR;
 
 	int retval;
-	static int initialized = 0;
+	static int initialized;
 	if (initialized)
 		return ERROR_OK;
 
@@ -127,8 +126,8 @@ COMMAND_HANDLER(handle_init_command)
 	if (ERROR_OK != retval)
 		return ERROR_FAIL;
 
-	if ((retval = adapter_init(CMD_CTX)) != ERROR_OK)
-	{
+	retval = adapter_init(CMD_CTX);
+	if (retval != ERROR_OK) {
 		/* we must be able to set up the debug adapter */
 		return retval;
 	}
@@ -232,8 +231,7 @@ struct command_context *setup_command_handler(Jim_Interp *interp)
 	log_init();
 	LOG_DEBUG("log_init: complete");
 
-	const char *startup = openocd_startup_tcl;
-	struct command_context *cmd_ctx = command_init(startup, interp);
+	struct command_context *cmd_ctx = command_init(openocd_startup_tcl, interp);
 
 	/* register subsystem commands */
 	typedef int (*command_registrant_t)(struct command_context *cmd_ctx_value);
@@ -251,11 +249,9 @@ struct command_context *setup_command_handler(Jim_Interp *interp)
 		&mflash_register_commands,
 		NULL
 	};
-	for (unsigned i = 0; NULL != command_registrants[i]; i++)
-	{
+	for (unsigned i = 0; NULL != command_registrants[i]; i++) {
 		int retval = (*command_registrants[i])(cmd_ctx);
-		if (ERROR_OK != retval)
-		{
+		if (ERROR_OK != retval) {
 			command_done(cmd_ctx);
 			return NULL;
 		}
@@ -263,7 +259,7 @@ struct command_context *setup_command_handler(Jim_Interp *interp)
 	LOG_DEBUG("command registration: complete");
 
 	LOG_OUTPUT(OPENOCD_VERSION "\n"
-			"Licensed under GNU GPL v2\n");
+		"Licensed under GNU GPL v2\n");
 
 	global_cmd_ctx = cmd_ctx;
 
@@ -279,31 +275,36 @@ static int openocd_thread(int argc, char *argv[], struct command_context *cmd_ct
 	int ret;
 
 	if (parse_cmdline_args(cmd_ctx, argc, argv) != ERROR_OK)
-		return EXIT_FAILURE;
+		return ERROR_FAIL;
 
 	if (server_preinit() != ERROR_OK)
-		return EXIT_FAILURE;
+		return ERROR_FAIL;
 
 	ret = parse_config_file(cmd_ctx);
-	if (ret != ERROR_OK)
-		return EXIT_FAILURE;
+	if (ret == ERROR_COMMAND_CLOSE_CONNECTION)
+		return ERROR_OK;
+	else if (ret != ERROR_OK)
+		return ERROR_FAIL;
 
 	ret = server_init(cmd_ctx);
 	if (ERROR_OK != ret)
-		return EXIT_FAILURE;
+		return ERROR_FAIL;
 
-	if (init_at_startup)
-	{
+	if (init_at_startup) {
 		ret = command_run_line(cmd_ctx, "init");
 		if (ERROR_OK != ret)
-			return EXIT_FAILURE;
+			return ERROR_FAIL;
 	}
 
-	server_loop(cmd_ctx);
+	ret = server_loop(cmd_ctx);
 
-	server_quit();
+	int last_signal = server_quit();
+	if (last_signal != ERROR_OK)
+		return last_signal;
 
-	return ret;
+	if (ret != ERROR_OK)
+		return ERROR_FAIL;
+	return ERROR_OK;
 }
 
 /* normally this is the main() function entry, but if OpenOCD is linked
@@ -325,7 +326,7 @@ int openocd_main(int argc, char *argv[])
 		return EXIT_FAILURE;
 
 	LOG_OUTPUT("For bug reports, read\n\t"
-		"http://openocd.sourceforge.net/doc/doxygen/bugs.html"
+		"http://openocd.org/doc/doxygen/bugs.html"
 		"\n");
 
 	command_context_mode(cmd_ctx, COMMAND_CONFIG);
@@ -341,5 +342,10 @@ int openocd_main(int argc, char *argv[])
 
 	adapter_quit();
 
+	if (ERROR_FAIL == ret)
+		return EXIT_FAILURE;
+	else if (ERROR_OK != ret)
+		exit_on_signal(ret);
+
 	return ret;
 }