X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=src%2Fjtag%2Fzy1000%2Fzy1000.c;h=c5239ee8c33f46922a0cc4f33811ecc0a5e0e5e9;hp=924a8bf9befdba9b0bcef3d4ffab15477ccc1676;hb=84df52f9ea78e2d71bde648a16b69d80404c6421;hpb=c18947b947064e7eceed8047c42d4c8dfd8ae964 diff --git a/src/jtag/zy1000/zy1000.c b/src/jtag/zy1000/zy1000.c index 924a8bf9be..c5239ee8c3 100644 --- a/src/jtag/zy1000/zy1000.c +++ b/src/jtag/zy1000/zy1000.c @@ -36,8 +36,6 @@ /* low level command set */ -int zy1000_read(void); -static void zy1000_write(int tck, int tms, int tdi); void zy1000_reset(int trst, int srst); @@ -51,26 +49,26 @@ int zy1000_handle_zy1000_port_command(struct command_context_s *cmd_ctx, char *c static int zy1000_khz(int khz, int *jtag_speed) { - if (khz==0) + if (khz == 0) { - *jtag_speed=0; + *jtag_speed = 0; } else { - *jtag_speed=64000/khz; + *jtag_speed = 64000/khz; } return ERROR_OK; } static int zy1000_speed_div(int speed, int *khz) { - if (speed==0) + if (speed == 0) { *khz = 0; } else { - *khz=64000/speed; + *khz = 64000/speed; } return ERROR_OK; @@ -101,13 +99,13 @@ static bool readSRST(void) static int zy1000_srst_asserted(int *srst_asserted) { - *srst_asserted=readSRST(); + *srst_asserted = readSRST(); return ERROR_OK; } static int zy1000_power_dropout(int *dropout) { - *dropout=readPowerDropout(); + *dropout = readPowerDropout(); return ERROR_OK; } @@ -126,34 +124,22 @@ jtag_interface_t zy1000_interface = .srst_asserted = zy1000_srst_asserted, }; -static void zy1000_write(int tck, int tms, int tdi) -{ - -} - -int zy1000_read(void) -{ - return -1; -} - -extern bool readSRST(void); - void zy1000_reset(int trst, int srst) { LOG_DEBUG("zy1000 trst=%d, srst=%d", trst, srst); - if(!srst) + if (!srst) { ZY1000_POKE(ZY1000_JTAG_BASE+0x14, 0x00000001); } else { - /* Danger!!! if clk!=0 when in + /* Danger!!! if clk != 0 when in * idle in TAP_IDLE, reset halt on str912 will fail. */ ZY1000_POKE(ZY1000_JTAG_BASE+0x10, 0x00000001); } - if(!trst) + if (!trst) { ZY1000_POKE(ZY1000_JTAG_BASE+0x14, 0x00000002); } @@ -163,7 +149,7 @@ void zy1000_reset(int trst, int srst) ZY1000_POKE(ZY1000_JTAG_BASE+0x10, 0x00000002); } - if (trst||(srst&&(jtag_get_reset_config() & RESET_SRST_PULLS_TRST))) + if (trst||(srst && (jtag_get_reset_config() & RESET_SRST_PULLS_TRST))) { waitIdle(); /* we're now in the RESET state until trst is deasserted */ @@ -178,7 +164,7 @@ void zy1000_reset(int trst, int srst) if (!srst) { int i; - for (i=0; i<1000; i++) + for (i = 0; i<1000; i++) { // We don't want to sense our own reset, so we clear here. // There is of course a timing hole where we could loose @@ -190,7 +176,7 @@ void zy1000_reset(int trst, int srst) alive_sleep(1); } - if (i==1000) + if (i == 1000) { LOG_USER("SRST didn't deassert after %dms", i); } else if (i>1) @@ -202,7 +188,7 @@ void zy1000_reset(int trst, int srst) int zy1000_speed(int speed) { - if(speed == 0) + if (speed == 0) { /*0 means RCLK*/ speed = 0; @@ -211,7 +197,7 @@ int zy1000_speed(int speed) } else { - if(speed > 8190 || speed < 2) + if (speed > 8190 || speed < 2) { LOG_USER("valid ZY1000 jtag_speed=[8190,2]. Divisor is 64MHz / even values between 8190-2, i.e. min 7814Hz, max 32MHz"); return ERROR_INVALID_ARGUMENTS; @@ -274,11 +260,11 @@ static int jim_zy1000_version(Jim_Interp *interp, int argc, Jim_Obj *const *argv if ((argc < 1) || (argc > 2)) return JIM_ERR; char buff[128]; - const char *version_str=NULL; + const char *version_str = NULL; if (argc == 1) { - version_str=ZYLIN_OPENOCD_VERSION; + version_str = ZYLIN_OPENOCD_VERSION; } else { const char *str = Jim_GetString(argv[1], NULL); @@ -287,15 +273,15 @@ static int jim_zy1000_version(Jim_Interp *interp, int argc, Jim_Obj *const *argv int revision; revision = atol(ZYLIN_OPENOCD+strlen("XRevision: ")); sprintf(buff, "%d", revision); - version_str=buff; + version_str = buff; } else if (strcmp("zy1000", str) == 0) { - version_str=ZYLIN_VERSION; + version_str = ZYLIN_VERSION; } else if (strcmp("date", str) == 0) { - version_str=ZYLIN_DATE; + version_str = ZYLIN_DATE; } else { @@ -323,7 +309,7 @@ zylinjtag_Jim_Command_powerstatus(Jim_Interp *interp, cyg_uint32 status; ZY1000_PEEK(ZY1000_JTAG_BASE+0x10, status); - Jim_SetResult(interp, Jim_NewIntObj(interp, (status&0x80)!=0)); + Jim_SetResult(interp, Jim_NewIntObj(interp, (status&0x80) != 0)); return JIM_OK; } @@ -377,7 +363,7 @@ int interface_jtag_execute_queue(void) /* clear JTAG error register */ ZY1000_POKE(ZY1000_JTAG_BASE+0x14, 0x400); - if ((empty&0x400)!=0) + if ((empty&0x400) != 0) { LOG_WARNING("RCLK timeout"); /* the error is informative only as we don't want to break the firmware if there @@ -416,17 +402,17 @@ static void shiftValueInnerFlip(const tap_state_t state, const tap_state_t endSt { VERBOSE(LOG_INFO("shiftValueInner %s %s %d %08x (flipped)", tap_state_name(state), tap_state_name(endState), repeat, value)); cyg_uint32 a,b; - a=state; - b=endState; + a = state; + b = endState; ZY1000_POKE(ZY1000_JTAG_BASE+0xc, value); - ZY1000_POKE(ZY1000_JTAG_BASE+0x8, (1<<15)|(repeat<<8)|(a<<4)|b); + ZY1000_POKE(ZY1000_JTAG_BASE+0x8, (1 << 15)|(repeat << 8)|(a << 4)|b); VERBOSE(getShiftValueFlip()); } #endif extern int jtag_check_value(uint8_t *captured, void *priv); -static __inline void scanFields(int num_fields, scan_field_t *fields, tap_state_t shiftState, tap_state_t end_state) +static __inline void scanFields(int num_fields, const scan_field_t *fields, tap_state_t shiftState, tap_state_t end_state) { int i; int j; @@ -436,64 +422,62 @@ static __inline void scanFields(int num_fields, scan_field_t *fields, tap_state_ { cyg_uint32 value; - static uint8_t *in_buff=NULL; /* pointer to buffer for scanned data */ - static int in_buff_size=0; - uint8_t *inBuffer=NULL; + uint8_t *inBuffer = NULL; // figure out where to store the input data - int num_bits=fields[i].num_bits; - if (fields[i].in_value!=NULL) + int num_bits = fields[i].num_bits; + if (fields[i].in_value != NULL) { - inBuffer=fields[i].in_value; + inBuffer = fields[i].in_value; } // here we shuffle N bits out/in - j=0; + j = 0; while (j32) { - k=32; + k = 32; /* we have more to shift out */ } else if (i == num_fields-1) { /* this was the last to shift out this time */ - pause_state=end_state; + pause_state = end_state; } // we have (num_bits+7)/8 bytes of bits to toggle out. // bits are pushed out LSB to MSB - value=0; - if (fields[i].out_value!=NULL) + value = 0; + if (fields[i].out_value != NULL) { - for (l=0; l>= 32-k; - for (l=0; l>l)&0xff; + inBuffer[(j+l)/8]=(value >> l)&0xff; } } - j+=k; + j += k; } } } @@ -510,11 +494,11 @@ int interface_jtag_add_ir_scan(int num_fields, const scan_field_t *fields, tap_s int j; int scan_size = 0; jtag_tap_t *tap, *nextTap; - for(tap = jtag_tap_next_enabled(NULL); tap!= NULL; tap=nextTap) + for (tap = jtag_tap_next_enabled(NULL); tap!= NULL; tap = nextTap) { - nextTap=jtag_tap_next_enabled(tap); + nextTap = jtag_tap_next_enabled(tap); tap_state_t end_state; - if (nextTap==NULL) + if (nextTap == NULL) { end_state = state; } else @@ -527,7 +511,7 @@ int interface_jtag_add_ir_scan(int num_fields, const scan_field_t *fields, tap_s scan_size = tap->ir_length; /* search the list */ - for (j=0; j < num_fields; j++) + for (j = 0; j < num_fields; j++) { if (tap == fields[j].tap) { @@ -579,12 +563,12 @@ int interface_jtag_add_dr_scan(int num_fields, const scan_field_t *fields, tap_s int j; jtag_tap_t *tap, *nextTap; - for(tap = jtag_tap_next_enabled(NULL); tap!= NULL; tap=nextTap) + for (tap = jtag_tap_next_enabled(NULL); tap!= NULL; tap = nextTap) { - nextTap=jtag_tap_next_enabled(tap); - int found=0; + nextTap = jtag_tap_next_enabled(tap); + int found = 0; tap_state_t end_state; - if (nextTap==NULL) + if (nextTap == NULL) { end_state = state; } else @@ -592,7 +576,7 @@ int interface_jtag_add_dr_scan(int num_fields, const scan_field_t *fields, tap_s end_state = TAP_DRSHIFT; } - for (j=0; j < num_fields; j++) + for (j = 0; j < num_fields; j++) { if (tap == fields[j].tap) { @@ -650,13 +634,13 @@ static int zy1000_jtag_add_clocks(int num_cycles, tap_state_t state, tap_state_t /* execute num_cycles, 32 at the time. */ int i; - for (i=0; i