X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=src%2Fjtag%2Fgw16012.c;h=63dcd627f3d4a1517e6461e33939a490e543f129;hp=720744a0b4565f4a95cbc039b86eb0fbdfdd0acf;hb=f90d8fa45f2d4c9d4b7990f198b232ee55cbb4e1;hpb=490e2712904a718efb320d0557f3bb8485676709 diff --git a/src/jtag/gw16012.c b/src/jtag/gw16012.c index 720744a0b4..63dcd627f3 100644 --- a/src/jtag/gw16012.c +++ b/src/jtag/gw16012.c @@ -21,9 +21,9 @@ #include "config.h" #endif -#include "replacements.h" +#include "interface.h" +#include "commands.h" -#include "jtag.h" #if 1 #define _DEBUG_GW16012_IO_ @@ -40,14 +40,8 @@ #else -#ifdef _WIN32 -#include "errno.h" -#endif /* _WIN32 */ - #endif /* __FreeBSD__, __FreeBSD_kernel__ */ -#include -#include #if PARPORT_USE_PPDEV == 1 #if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) @@ -67,22 +61,18 @@ #endif #endif -#if PARPORT_USE_GIVEIO == 1 -#if IS_CYGWIN == 1 +#if PARPORT_USE_GIVEIO == 1 && IS_CYGWIN == 1 #include -#include -#endif #endif -#include "log.h" /* configuration */ -u16 gw16012_port; +uint16_t gw16012_port; /* interface variables */ -static u8 gw16012_msb = 0x0; -static u8 gw16012_control_value = 0x0; +static uint8_t gw16012_msb = 0x0; +static uint8_t gw16012_control_value = 0x0; #if PARPORT_USE_PPDEV == 1 static int device_handle; @@ -116,7 +106,7 @@ static int gw16012_register_commands(struct command_context_s *cmd_ctx) return ERROR_OK; } -static void gw16012_data(u8 value) +static void gw16012_data(uint8_t value) { value = (value & 0x7f) | gw16012_msb; gw16012_msb ^= 0x80; /* toggle MSB */ @@ -136,7 +126,7 @@ static void gw16012_data(u8 value) #endif } -static void gw16012_control(u8 value) +static void gw16012_control(uint8_t value) { if (value != gw16012_control_value) { @@ -158,7 +148,7 @@ static void gw16012_control(u8 value) } } -static void gw16012_input(u8 *value) +static void gw16012_input(uint8_t *value) { #if PARPORT_USE_PPDEV == 1 ioctl(device_handle, PPRSTATUS, value); @@ -206,12 +196,13 @@ static void gw16012_end_state(tap_state_t state) static void gw16012_state_move(void) { - int i=0, tms=0; - u8 tms_scan = tap_get_tms_path(tap_get_state(), tap_get_end_state()); + int i = 0, tms = 0; + uint8_t tms_scan = tap_get_tms_path(tap_get_state(), tap_get_end_state()); + int tms_count = tap_get_tms_path_len(tap_get_state(), tap_get_end_state()); gw16012_control(0x0); /* single-bit mode */ - for (i = 0; i < 7; i++) + for (i = 0; i < tms_count; i++) { tms = (tms_scan >> i) & 1; gw16012_data(tms << 1); /* output next TMS bit */ @@ -274,12 +265,12 @@ static void gw16012_runtest(int num_cycles) gw16012_state_move(); } -static void gw16012_scan(int ir_scan, enum scan_type type, u8 *buffer, int scan_size) +static void gw16012_scan(bool ir_scan, enum scan_type type, uint8_t *buffer, int scan_size) { int bits_left = scan_size; int bit_count = 0; tap_state_t saved_end_state = tap_get_end_state(); - u8 scan_out, scan_in; + uint8_t scan_out, scan_in; /* only if we're not already in the correct Shift state */ if (!((!ir_scan && (tap_get_state() == TAP_DRSHIFT)) || (ir_scan && (tap_get_state() == TAP_IRSHIFT)))) @@ -305,7 +296,7 @@ static void gw16012_scan(int ir_scan, enum scan_type type, u8 *buffer, int scan_ gw16012_control(0x0); /* single-bit mode */ while (bits_left-- > 0) { - u8 tms = 0; + uint8_t tms = 0; scan_out = buf_get_u32(buffer, bit_count, 1); @@ -352,7 +343,7 @@ static int gw16012_execute_queue(void) jtag_command_t *cmd = jtag_command_queue; /* currently processed command */ int scan_size; enum scan_type type; - u8 *buffer; + uint8_t *buffer; int retval; /* return ERROR_OK, unless a jtag_read_buffer returns a failed check @@ -364,13 +355,6 @@ static int gw16012_execute_queue(void) { switch (cmd->type) { - case JTAG_END_STATE: -#ifdef _DEBUG_JTAG_IO_ - LOG_DEBUG("end_state: %i", cmd->cmd.end_state->end_state); -#endif - if (cmd->cmd.end_state->end_state != TAP_INVALID) - gw16012_end_state(cmd->cmd.end_state->end_state); - break; case JTAG_RESET: #ifdef _DEBUG_JTAG_IO_ LOG_DEBUG("reset trst: %i srst %i", cmd->cmd.reset->trst, cmd->cmd.reset->srst); @@ -385,16 +369,14 @@ static int gw16012_execute_queue(void) #ifdef _DEBUG_JTAG_IO_ LOG_DEBUG("runtest %i cycles, end in %i", cmd->cmd.runtest->num_cycles, cmd->cmd.runtest->end_state); #endif - if (cmd->cmd.runtest->end_state != TAP_INVALID) - gw16012_end_state(cmd->cmd.runtest->end_state); + gw16012_end_state(cmd->cmd.runtest->end_state); gw16012_runtest(cmd->cmd.runtest->num_cycles); break; case JTAG_STATEMOVE: #ifdef _DEBUG_JTAG_IO_ LOG_DEBUG("statemove end in %i", cmd->cmd.statemove->end_state); #endif - if (cmd->cmd.statemove->end_state != TAP_INVALID) - gw16012_end_state(cmd->cmd.statemove->end_state); + gw16012_end_state(cmd->cmd.statemove->end_state); gw16012_state_move(); break; case JTAG_PATHMOVE: @@ -404,8 +386,7 @@ static int gw16012_execute_queue(void) gw16012_path_move(cmd->cmd.pathmove); break; case JTAG_SCAN: - if (cmd->cmd.scan->end_state != TAP_INVALID) - gw16012_end_state(cmd->cmd.scan->end_state); + gw16012_end_state(cmd->cmd.scan->end_state); scan_size = jtag_build_buffer(cmd->cmd.scan, &buffer); type = jtag_scan_type(cmd->cmd.scan); #ifdef _DEBUG_JTAG_IO_ @@ -441,20 +422,20 @@ static int gw16012_get_giveio_access(void) OSVERSIONINFO version; version.dwOSVersionInfoSize = sizeof version; - if (!GetVersionEx( &version )) { + if (!GetVersionEx(&version )) { errno = EINVAL; return -1; } if (version.dwPlatformId != VER_PLATFORM_WIN32_NT) return 0; - h = CreateFile( "\\\\.\\giveio", GENERIC_READ, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL ); + h = CreateFile("\\\\.\\giveio", GENERIC_READ, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL ); if (h == INVALID_HANDLE_VALUE) { errno = ENODEV; return -1; } - CloseHandle( h ); + CloseHandle(h ); return 0; } @@ -519,7 +500,7 @@ static int gw16012_init_device(void) LOG_DEBUG("opening %s...", buffer); device_handle = open(buffer, O_WRONLY); - if (device_handle<0) + if (device_handle < 0) { LOG_ERROR("cannot open device. check it exists and that user read and write rights are set"); return ERROR_JTAG_INIT_FAILED; @@ -568,7 +549,7 @@ static int gw16012_init_device(void) static int gw16012_init(void) { - u8 status_port; + uint8_t status_port; if (gw16012_init_device() != ERROR_OK) return ERROR_JTAG_INIT_FAILED; @@ -576,7 +557,7 @@ static int gw16012_init(void) gw16012_input(&status_port); gw16012_msb = (status_port & 0x80) ^ 0x80; - gw16012_speed(jtag_speed); + gw16012_speed(jtag_get_speed()); gw16012_reset(0, 0); return ERROR_OK; @@ -590,12 +571,23 @@ static int gw16012_quit(void) static int gw16012_handle_parport_port_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc) { - if (argc == 0) - return ERROR_OK; + if (argc == 1) + { + /* only if the port wasn't overwritten by cmdline */ + if (gw16012_port == 0) + { + int retval = parse_u16(args[0], &gw16012_port); + if (ERROR_OK != retval) + return retval; + } + else + { + LOG_ERROR("The parport port was already configured!"); + return ERROR_FAIL; + } + } - /* only if the port wasn't overwritten by cmdline */ - if (gw16012_port == 0) - gw16012_port = strtoul(args[0], NULL, 0); + command_print(cmd_ctx, "parport port = %u", gw16012_port); return ERROR_OK; }