X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=HACKING;h=ed971715406b79db363d395920915294ed7dfcc8;hp=353e72f165c06191617cb77a0e00484360d55762;hb=ac4340e39170d6cc97f9de430a52b69a9a22567e;hpb=61957bee47aed12016b2576bf88856f916c82b10

diff --git a/HACKING b/HACKING
index 353e72f165..ed97171540 100644
--- a/HACKING
+++ b/HACKING
@@ -92,6 +92,7 @@ repository.
 while(!done) {
   work - edit files using your favorite editor.
   run "git commit -s -a" to commit all changes.
+  run tools/checkpatch.sh to verify your patch style is ok.
 }
 
 TIP! use "git add ." before commit to add new files.
@@ -120,4 +121,25 @@ git push review
 
 Further reading:
 
-http://www.coreboot.org/Git
\ No newline at end of file
+http://www.coreboot.org/Git
+
+
+When can I expect my contribution to be committed?
+==================================================
+
+The code review is intended to take as long as a week or two to allow
+maintainers and contributors who work on OpenOCD only in their spare
+time oportunity to perform a review and raise objections.
+
+With Gerrit much of the urgency of getting things committed has been
+removed as the work in progress is safely stored in Gerrit and
+available if someone needs to build on your work before it is
+submitted to the official repository.
+
+Another factor that contributes to the desire for longer cool-off
+times (the time a patch lies around without any further changes or
+comments), it means that the chances of quality regression on the
+master branch will be much reduced.
+
+If a contributor pushes a patch, it is considered good form if another
+contributor actually approves and submits that patch.