smp: Fix byte order bug

[openocd.git] / src / target / smp.c

diff --git a/src/target/smp.c b/src/target/smp.c
index 39a95337d3bb1fa86d960f0d7755be3bf588623d..d14ceba962283c2d460db3ccbb84c67c5ef4654e 100644 (file)
--- a/src/target/smp.c
+++ b/src/target/smp.c
@@ -59,18 +59,16 @@ int gdb_read_smp_packet(struct connection *connection,
                char *packet, int packet_size)
 {
        struct target *target = get_target_from_connection(connection);
                char *packet, int packet_size)
 {
        struct target *target = get_target_from_connection(connection);

-       uint32_t len = sizeof(int32_t);
-       uint8_t *buffer;
-       char *hex_buffer;

        int retval = ERROR_OK;
        if (target->smp) {
                if (strncmp(packet, "jc", 2) == 0) {
        int retval = ERROR_OK;
        if (target->smp) {
                if (strncmp(packet, "jc", 2) == 0) {

-                       hex_buffer = malloc(len * 2 + 1);
-                       buffer = (uint8_t *)&target->gdb_service->core[0];
-                       int pkt_len = hexify(hex_buffer, (char *)buffer, len, len * 2 + 1);
+                       const uint32_t len = sizeof(target->gdb_service->core[0]);
+                       char hex_buffer[len * 2 + 1];
+                       char buffer[len];
+                       buf_set_u32(buffer, 0, len * 8, target->gdb_service->core[0]);
+                       int pkt_len = hexify(hex_buffer, buffer, sizeof(buffer), sizeof(hex_buffer));

 
                        retval = gdb_put_packet(connection, hex_buffer, pkt_len);
 
                        retval = gdb_put_packet(connection, hex_buffer, pkt_len);

-                       free(hex_buffer);

                }
        } else
                retval = gdb_put_packet(connection, "E01", 3);
                }
        } else
                retval = gdb_put_packet(connection, "E01", 3);