Remove unnecessary (void *)
[openocd.git] / src / target / arm_semihosting.c
index 9b853d9f942d08da4fc29412238948ca6a09eaaa..06a433f22b7233e96d08f3d7c3e19ad421f84c30 100644 (file)
@@ -18,7 +18,7 @@
  *   You should have received a copy of the GNU General Public License     *
  *   along with this program; if not, write to the                         *
  *   Free Software Foundation, Inc.,                                       *
- *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
+ *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.           *
  ***************************************************************************/
 
 /**
@@ -39,6 +39,9 @@
 
 #include "arm.h"
 #include "armv4_5.h"
+#include "arm7_9_common.h"
+#include "armv7m.h"
+#include "cortex_m.h"
 #include "register.h"
 #include "arm_semihosting.h"
 #include <helper/binarybuffer.h>
@@ -62,11 +65,9 @@ static int open_modeflags[12] = {
 
 static int do_semihosting(struct target *target)
 {
-       struct arm *armv4_5 = target_to_arm(target);
-       uint32_t r0 = buf_get_u32(armv4_5->core_cache->reg_list[0].value, 0, 32);
-       uint32_t r1 = buf_get_u32(armv4_5->core_cache->reg_list[1].value, 0, 32);
-       uint32_t lr = buf_get_u32(ARMV4_5_CORE_REG_MODE(armv4_5->core_cache, ARM_MODE_SVC, 14).value, 0, 32);
-       uint32_t spsr = buf_get_u32(armv4_5->spsr->value, 0, 32);;
+       struct arm *arm = target_to_arm(target);
+       uint32_t r0 = buf_get_u32(arm->core_cache->reg_list[0].value, 0, 32);
+       uint32_t r1 = buf_get_u32(arm->core_cache->reg_list[1].value, 0, 32);
        uint8_t params[16];
        int retval, result;
 
@@ -105,10 +106,10 @@ static int do_semihosting(struct target *target)
                                         * written file */
                                        result = open((char *)fn, open_modeflags[m], 0644);
                                }
-                               armv4_5->semihosting_errno =  errno;
+                               arm->semihosting_errno =  errno;
                        } else {
                                result = -1;
-                               armv4_5->semihosting_errno = EINVAL;
+                               arm->semihosting_errno = EINVAL;
                        }
                }
                break;
@@ -120,7 +121,7 @@ static int do_semihosting(struct target *target)
                else {
                        int fd = target_buffer_get_u32(target, params+0);
                        result = close(fd);
-                       armv4_5->semihosting_errno = errno;
+                       arm->semihosting_errno = errno;
                }
                break;
 
@@ -138,7 +139,7 @@ static int do_semihosting(struct target *target)
        case 0x04:      /* SYS_WRITE0 */
                do {
                        unsigned char c;
-                       retval = target_read_memory(target, r1, 1, 1, &c);
+                       retval = target_read_memory(target, r1++, 1, 1, &c);
                        if (retval != ERROR_OK)
                                return retval;
                        if (!c)
@@ -159,7 +160,7 @@ static int do_semihosting(struct target *target)
                        uint8_t *buf = malloc(l);
                        if (!buf) {
                                result = -1;
-                               armv4_5->semihosting_errno = ENOMEM;
+                               arm->semihosting_errno = ENOMEM;
                        } else {
                                retval = target_read_buffer(target, a, l, buf);
                                if (retval != ERROR_OK) {
@@ -167,7 +168,7 @@ static int do_semihosting(struct target *target)
                                        return retval;
                                }
                                result = write(fd, buf, l);
-                               armv4_5->semihosting_errno = errno;
+                               arm->semihosting_errno = errno;
                                if (result >= 0)
                                        result = l - result;
                                free(buf);
@@ -186,10 +187,10 @@ static int do_semihosting(struct target *target)
                        uint8_t *buf = malloc(l);
                        if (!buf) {
                                result = -1;
-                               armv4_5->semihosting_errno = ENOMEM;
+                               arm->semihosting_errno = ENOMEM;
                        } else {
                                result = read(fd, buf, l);
-                               armv4_5->semihosting_errno = errno;
+                               arm->semihosting_errno = errno;
                                if (result >= 0) {
                                        retval = target_write_buffer(target, a, result, buf);
                                        if (retval != ERROR_OK) {
@@ -229,7 +230,7 @@ static int do_semihosting(struct target *target)
                        int fd = target_buffer_get_u32(target, params+0);
                        off_t pos = target_buffer_get_u32(target, params+4);
                        result = lseek(fd, pos, SEEK_SET);
-                       armv4_5->semihosting_errno = errno;
+                       arm->semihosting_errno = errno;
                        if (result == pos)
                                result = 0;
                }
@@ -244,7 +245,7 @@ static int do_semihosting(struct target *target)
                        struct stat buf;
                        result = fstat(fd, &buf);
                        if (result == -1) {
-                               armv4_5->semihosting_errno = errno;
+                               arm->semihosting_errno = errno;
                                result = -1;
                                break;
                        }
@@ -266,10 +267,10 @@ static int do_semihosting(struct target *target)
                                        return retval;
                                fn[l] = 0;
                                result = remove((char *)fn);
-                               armv4_5->semihosting_errno =  errno;
+                               arm->semihosting_errno =  errno;
                        } else {
                                result = -1;
-                               armv4_5->semihosting_errno = EINVAL;
+                               arm->semihosting_errno = EINVAL;
                        }
                }
                break;
@@ -294,10 +295,10 @@ static int do_semihosting(struct target *target)
                                fn1[l1] = 0;
                                fn2[l2] = 0;
                                result = rename((char *)fn1, (char *)fn2);
-                               armv4_5->semihosting_errno =  errno;
+                               arm->semihosting_errno =  errno;
                        } else {
                                result = -1;
-                               armv4_5->semihosting_errno = EINVAL;
+                               arm->semihosting_errno = EINVAL;
                        }
                }
                break;
@@ -307,7 +308,7 @@ static int do_semihosting(struct target *target)
                break;
 
        case 0x13:      /* SYS_ERRNO */
-               result = armv4_5->semihosting_errno;
+               result = arm->semihosting_errno;
                break;
 
        case 0x15:      /* SYS_GET_CMDLINE */
@@ -322,7 +323,7 @@ static int do_semihosting(struct target *target)
                        if (l < s)
                                result = -1;
                        else {
-                               retval = target_write_buffer(target, a, s, (void*)arg);
+                               retval = target_write_buffer(target, a, s, (uint8_t *)arg);
                                if (retval != ERROR_OK)
                                        return retval;
                                result = 0;
@@ -373,9 +374,34 @@ static int do_semihosting(struct target *target)
                }
                return target_call_event_callbacks(target, TARGET_EVENT_HALTED);
 
+       case 0x12:      /* SYS_SYSTEM */
+               /* Provide SYS_SYSTEM functionality.  Uses the
+                * libc system command, there may be a reason *NOT*
+                * to use this, but as I can't think of one, I
+                * implemented it this way.
+                */
+               retval = target_read_memory(target, r1, 4, 2, params);
+               if (retval != ERROR_OK)
+                       return retval;
+               else {
+                       uint32_t len = target_buffer_get_u32(target, params+4);
+                       uint32_t c_ptr = target_buffer_get_u32(target, params);
+                       uint8_t cmd[256];
+                       if (len > 255) {
+                               result = -1;
+                               arm->semihosting_errno = EINVAL;
+                       } else {
+                               memset(cmd, 0x0, 256);
+                               retval = target_read_memory(target, c_ptr, 1, len, cmd);
+                               if (retval != ERROR_OK)
+                                       return retval;
+                               else
+                                       result = system((const char *)cmd);
+                       }
+               }
+               break;
        case 0x0d:      /* SYS_TMPNAM */
        case 0x10:      /* SYS_CLOCK */
-       case 0x12:      /* SYS_SYSTEM */
        case 0x17:      /* angel_SWIreason_EnterSVC */
        case 0x30:      /* SYS_ELAPSED */
        case 0x31:      /* SYS_TICKFREQ */
@@ -383,25 +409,47 @@ static int do_semihosting(struct target *target)
                fprintf(stderr, "semihosting: unsupported call %#x\n",
                                (unsigned) r0);
                result = -1;
-               armv4_5->semihosting_errno = ENOTSUP;
+               arm->semihosting_errno = ENOTSUP;
        }
 
        /* resume execution to the original mode */
 
-       /* return value in R0 */
-       buf_set_u32(armv4_5->core_cache->reg_list[0].value, 0, 32, result);
-       armv4_5->core_cache->reg_list[0].dirty = 1;
+       /* REVISIT this looks wrong ... ARM11 and Cortex-A8
+        * should work this way at least sometimes.
+        */
+       if (is_arm7_9(target_to_arm7_9(target))) {
+               uint32_t spsr;
+
+               /* return value in R0 */
+               buf_set_u32(arm->core_cache->reg_list[0].value, 0, 32, result);
+               arm->core_cache->reg_list[0].dirty = 1;
 
-       /* LR --> PC */
-       buf_set_u32(armv4_5->core_cache->reg_list[15].value, 0, 32, lr);
-       armv4_5->core_cache->reg_list[15].dirty = 1;
+               /* LR --> PC */
+               buf_set_u32(arm->core_cache->reg_list[15].value, 0, 32,
+                       buf_get_u32(arm_reg_current(arm, 14)->value, 0, 32));
+               arm->core_cache->reg_list[15].dirty = 1;
 
-       /* saved PSR --> current PSR */
-       buf_set_u32(armv4_5->cpsr->value, 0, 32, spsr);
-       armv4_5->cpsr->dirty = 1;
-       armv4_5->core_mode = spsr & 0x1f;
-       if (spsr & 0x20)
-               armv4_5->core_state = ARM_STATE_THUMB;
+               /* saved PSR --> current PSR */
+               spsr = buf_get_u32(arm->spsr->value, 0, 32);
+
+               /* REVISIT should this be arm_set_cpsr(arm, spsr)
+                * instead of a partially unrolled version?
+                */
+
+               buf_set_u32(arm->cpsr->value, 0, 32, spsr);
+               arm->cpsr->dirty = 1;
+               arm->core_mode = spsr & 0x1f;
+               if (spsr & 0x20)
+                       arm->core_state = ARM_STATE_THUMB;
+
+       } else {
+               /* resume execution, this will be pc+2 to skip over the
+                * bkpt instruction */
+
+               /* return result in R0 */
+               buf_set_u32(arm->core_cache->reg_list[0].value, 0, 32, result);
+               arm->core_cache->reg_list[0].dirty = 1;
+       }
 
        return target_resume(target, 1, 0, 0, 0);
 }
@@ -425,59 +473,84 @@ int arm_semihosting(struct target *target, int *retval)
        uint32_t pc, lr, spsr;
        struct reg *r;
 
-       if (!arm->is_semihosting || arm->core_mode != ARM_MODE_SVC)
+       if (!arm->is_semihosting)
                return 0;
 
-       /* Check for PC == 0x00000008 or 0xffff0008: Supervisor Call vector. */
-       r = arm->core_cache->reg_list + 15;
-       pc = buf_get_u32(r->value, 0, 32);
-       if (pc != 0x00000008 && pc != 0xffff0008)
-               return 0;
+       if (is_arm7_9(target_to_arm7_9(target))) {
+               if (arm->core_mode != ARM_MODE_SVC)
+                       return 0;
 
-       r = arm_reg_current(arm, 14);
-       lr = buf_get_u32(r->value, 0, 32);
+               /* Check for PC == 0x00000008 or 0xffff0008: Supervisor Call vector. */
+               r = arm->pc;
+               pc = buf_get_u32(r->value, 0, 32);
+               if (pc != 0x00000008 && pc != 0xffff0008)
+                       return 0;
 
-       /* Core-specific code should make sure SPSR is retrieved
-        * when the above checks pass...
-        */
-       if (!arm->spsr->valid) {
-               LOG_ERROR("SPSR not valid!");
-               *retval = ERROR_FAIL;
-               return 1;
-       }
+               r = arm_reg_current(arm, 14);
+               lr = buf_get_u32(r->value, 0, 32);
 
-       spsr = buf_get_u32(arm->spsr->value, 0, 32);
+               /* Core-specific code should make sure SPSR is retrieved
+                * when the above checks pass...
+                */
+               if (!arm->spsr->valid) {
+                       LOG_ERROR("SPSR not valid!");
+                       *retval = ERROR_FAIL;
+                       return 1;
+               }
 
-       /* check instruction that triggered this trap */
-       if (spsr & (1 << 5)) {
-               /* was in Thumb (or ThumbEE) mode */
-               uint8_t insn_buf[2];
-               uint16_t insn;
+               spsr = buf_get_u32(arm->spsr->value, 0, 32);
 
-               *retval = target_read_memory(target, lr-2, 2, 1, insn_buf);
-               if (*retval != ERROR_OK)
-                       return 1;
-               insn = target_buffer_get_u16(target, insn_buf);
+               /* check instruction that triggered this trap */
+               if (spsr & (1 << 5)) {
+                       /* was in Thumb (or ThumbEE) mode */
+                       uint8_t insn_buf[2];
+                       uint16_t insn;
 
-               /* SVC 0xab */
-               if (insn != 0xDFAB)
+                       *retval = target_read_memory(target, lr-2, 2, 1, insn_buf);
+                       if (*retval != ERROR_OK)
+                               return 1;
+                       insn = target_buffer_get_u16(target, insn_buf);
+
+                       /* SVC 0xab */
+                       if (insn != 0xDFAB)
+                               return 0;
+               } else if (spsr & (1 << 24)) {
+                       /* was in Jazelle mode */
                        return 0;
-       } else if (spsr & (1 << 24)) {
-               /* was in Jazelle mode */
-               return 0;
-       } else {
-               /* was in ARM mode */
-               uint8_t insn_buf[4];
-               uint32_t insn;
+               } else {
+                       /* was in ARM mode */
+                       uint8_t insn_buf[4];
+                       uint32_t insn;
+
+                       *retval = target_read_memory(target, lr-4, 4, 1, insn_buf);
+                       if (*retval != ERROR_OK)
+                               return 1;
+                       insn = target_buffer_get_u32(target, insn_buf);
+
+                       /* SVC 0x123456 */
+                       if (insn != 0xEF123456)
+                               return 0;
+               }
+       } else if (is_armv7m(target_to_armv7m(target))) {
+               uint16_t insn;
 
-               *retval = target_read_memory(target, lr-4, 4, 1, insn_buf);
+               if (target->debug_reason != DBG_REASON_BREAKPOINT)
+                       return 0;
+
+               r = arm->pc;
+               pc = buf_get_u32(r->value, 0, 32);
+
+               pc &= ~1;
+               *retval = target_read_u16(target, pc, &insn);
                if (*retval != ERROR_OK)
                        return 1;
-               insn = target_buffer_get_u32(target, insn_buf);
 
-               /* SVC 0x123456 */
-               if (insn != 0xEF123456)
+               /* bkpt 0xAB */
+               if (insn != 0xBEAB)
                        return 0;
+       } else {
+               LOG_ERROR("Unsupported semi-hosting Target");
+               return 0;
        }
 
        *retval = do_semihosting(target);

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)