add const keyword to some APIs
[openocd.git] / src / pld / xilinx_bit.c
index 8dd2ee460ccd738e3cf755a4b4cfe25d4752694e..33c3ed79b7b24940c8dd4e85b74d1bee6d8fc6cd 100644 (file)
 #endif
 
 #include "xilinx_bit.h"
-
 #include "pld.h"
 #include "log.h"
 
-#include <stdlib.h>
-#include <unistd.h>
-#include <sys/types.h>
 #include <sys/stat.h>
-#include <fcntl.h>
-#include <string.h>
-#include <errno.h>
 
-#include <sys/time.h>
-#include <time.h>
 
-int read_section(FILE *input_file, int length_size, char section, u32 *buffer_length, u8 **buffer) 
+static int read_section(FILE *input_file, int length_size, char section,
+               uint32_t *buffer_length, uint8_t **buffer)
 {
-       u8 length_buffer[4];
+       uint8_t length_buffer[4];
        int length;
        char section_char;
        int read_count;
-       
+
        if ((length_size != 2) && (length_size != 4))
        {
                LOG_ERROR("BUG: length_size neither 2 nor 4");
@@ -54,7 +46,7 @@ int read_section(FILE *input_file, int length_size, char section, u32 *buffer_le
        {
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
-       
+
        if (section_char != section)
        {
                return ERROR_PLD_FILE_LOAD_FAILED;
@@ -64,34 +56,34 @@ int read_section(FILE *input_file, int length_size, char section, u32 *buffer_le
        {
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
-       
+
        if (length_size == 4)
                length = be_to_h_u32(length_buffer);
        else /* (length_size == 2) */
                length = be_to_h_u16(length_buffer);
-               
+
        if (buffer_length)
                *buffer_length = length;
-       
+
        *buffer = malloc(length);
-       
+
        if ((read_count = fread(*buffer, 1, length, input_file)) != length)
        {
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
-       
+
        return ERROR_OK;
 }
 
-int xilinx_read_bit_file(xilinx_bit_file_t *bit_file, char *filename)
+int xilinx_read_bit_file(xilinx_bit_file_t *bit_file, const char *filename)
 {
        FILE *input_file;
        struct stat input_stat;
        int read_count;
-       
+
        if (!filename || !bit_file)
                return ERROR_INVALID_ARGUMENTS;
-       
+
        if (stat(filename, &input_stat) == -1)
        {
                LOG_ERROR("couldn't stat() %s: %s", filename, strerror(errno));
@@ -103,30 +95,30 @@ int xilinx_read_bit_file(xilinx_bit_file_t *bit_file, char *filename)
                LOG_ERROR("%s is a directory", filename);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
-               
-       if (input_stat.st_size == 0){
+
+       if (input_stat.st_size == 0) {
                LOG_ERROR("Empty file %s", filename);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
-               
+
        if (!(input_file = fopen(filename, "rb")))
        {
                LOG_ERROR("couldn't open %s: %s", filename, strerror(errno));
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
-       
+
        if ((read_count = fread(bit_file->unknown_header, 1, 13, input_file)) != 13)
        {
                LOG_ERROR("couldn't read unknown_header from file '%s'", filename);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
-       
+
        if (read_section(input_file, 2, 'a', NULL, &bit_file->source_file) != ERROR_OK)
                return ERROR_PLD_FILE_LOAD_FAILED;
-       
+
        if (read_section(input_file, 2, 'b', NULL, &bit_file->part_name) != ERROR_OK)
                return ERROR_PLD_FILE_LOAD_FAILED;
-       
+
        if (read_section(input_file, 2, 'c', NULL, &bit_file->date) != ERROR_OK)
                return ERROR_PLD_FILE_LOAD_FAILED;
 
@@ -135,11 +127,11 @@ int xilinx_read_bit_file(xilinx_bit_file_t *bit_file, char *filename)
 
        if (read_section(input_file, 4, 'e', &bit_file->length, &bit_file->data) != ERROR_OK)
                return ERROR_PLD_FILE_LOAD_FAILED;
-       
-       LOG_DEBUG("bit_file: %s %s %s,%s %i", bit_file->source_file, bit_file->part_name,
+
+       LOG_DEBUG("bit_file: %s %s %s,%s %" PRIi32 "", bit_file->source_file, bit_file->part_name,
                bit_file->date, bit_file->time, bit_file->length);
-       
+
        fclose(input_file);
-       
+
        return ERROR_OK;
 }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)