target/hla_target: fix clang static analyzer warning
[openocd.git] / src / target / hla_target.c
1 /***************************************************************************
2 * Copyright (C) 2011 by Mathias Kuester *
3 * Mathias Kuester <kesmtp@freenet.de> *
4 * *
5 * Copyright (C) 2011 by Spencer Oliver *
6 * spen@spen-soft.co.uk *
7 * *
8 * revised: 4/25/13 by brent@mbari.org [DCC target request support] *
9 * *
10 * This program is free software; you can redistribute it and/or modify *
11 * it under the terms of the GNU General Public License as published by *
12 * the Free Software Foundation; either version 2 of the License, or *
13 * (at your option) any later version. *
14 * *
15 * This program is distributed in the hope that it will be useful, *
16 * but WITHOUT ANY WARRANTY; without even the implied warranty of *
17 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
18 * GNU General Public License for more details. *
19 * *
20 * You should have received a copy of the GNU General Public License *
21 * along with this program. If not, see <http://www.gnu.org/licenses/>. *
22 ***************************************************************************/
23
24 #ifdef HAVE_CONFIG_H
25 #include "config.h"
26 #endif
27
28 #include "jtag/jtag.h"
29 #include "jtag/hla/hla_transport.h"
30 #include "jtag/hla/hla_interface.h"
31 #include "jtag/hla/hla_layout.h"
32 #include "register.h"
33 #include "algorithm.h"
34 #include "target.h"
35 #include "breakpoints.h"
36 #include "target_type.h"
37 #include "armv7m.h"
38 #include "cortex_m.h"
39 #include "arm_semihosting.h"
40 #include "target_request.h"
41
42 #define savedDCRDR dbgbase /* FIXME: using target->dbgbase to preserve DCRDR */
43
44 #define ARMV7M_SCS_DCRSR DCB_DCRSR
45 #define ARMV7M_SCS_DCRDR DCB_DCRDR
46
47 static inline struct hl_interface_s *target_to_adapter(struct target *target)
48 {
49 return target->tap->priv;
50 }
51
52 static int adapter_load_core_reg_u32(struct target *target,
53 uint32_t num, uint32_t *value)
54 {
55 int retval;
56 struct hl_interface_s *adapter = target_to_adapter(target);
57
58 LOG_DEBUG("%s", __func__);
59
60 /* NOTE: we "know" here that the register identifiers used
61 * in the v7m header match the Cortex-M3 Debug Core Register
62 * Selector values for R0..R15, xPSR, MSP, and PSP.
63 */
64 switch (num) {
65 case 0 ... 18:
66 /* read a normal core register */
67 retval = adapter->layout->api->read_reg(adapter->handle, num, value);
68
69 if (retval != ERROR_OK) {
70 LOG_ERROR("JTAG failure %i", retval);
71 return ERROR_JTAG_DEVICE_ERROR;
72 }
73 LOG_DEBUG("load from core reg %i value 0x%" PRIx32 "", (int)num, *value);
74 break;
75
76 case ARMV7M_FPSCR:
77 /* Floating-point Status and Registers */
78 retval = target_write_u32(target, ARMV7M_SCS_DCRSR, 33);
79 if (retval != ERROR_OK)
80 return retval;
81 retval = target_read_u32(target, ARMV7M_SCS_DCRDR, value);
82 if (retval != ERROR_OK)
83 return retval;
84 LOG_DEBUG("load from FPSCR value 0x%" PRIx32, *value);
85 break;
86
87 case ARMV7M_S0 ... ARMV7M_S31:
88 /* Floating-point Status and Registers */
89 retval = target_write_u32(target, ARMV7M_SCS_DCRSR, num-ARMV7M_S0+64);
90 if (retval != ERROR_OK)
91 return retval;
92 retval = target_read_u32(target, ARMV7M_SCS_DCRDR, value);
93 if (retval != ERROR_OK)
94 return retval;
95 LOG_DEBUG("load from FPU reg S%d value 0x%" PRIx32,
96 (int)(num - ARMV7M_S0), *value);
97 break;
98
99 case ARMV7M_PRIMASK:
100 case ARMV7M_BASEPRI:
101 case ARMV7M_FAULTMASK:
102 case ARMV7M_CONTROL:
103 /* Cortex-M3 packages these four registers as bitfields
104 * in one Debug Core register. So say r0 and r2 docs;
105 * it was removed from r1 docs, but still works.
106 */
107 retval = adapter->layout->api->read_reg(adapter->handle, 20, value);
108 if (retval != ERROR_OK)
109 return retval;
110
111 switch (num) {
112 case ARMV7M_PRIMASK:
113 *value = buf_get_u32((uint8_t *) value, 0, 1);
114 break;
115
116 case ARMV7M_BASEPRI:
117 *value = buf_get_u32((uint8_t *) value, 8, 8);
118 break;
119
120 case ARMV7M_FAULTMASK:
121 *value = buf_get_u32((uint8_t *) value, 16, 1);
122 break;
123
124 case ARMV7M_CONTROL:
125 *value = buf_get_u32((uint8_t *) value, 24, 2);
126 break;
127 }
128
129 LOG_DEBUG("load from special reg %i value 0x%" PRIx32 "",
130 (int)num, *value);
131 break;
132
133 default:
134 return ERROR_COMMAND_SYNTAX_ERROR;
135 }
136
137 return ERROR_OK;
138 }
139
140 static int adapter_store_core_reg_u32(struct target *target,
141 uint32_t num, uint32_t value)
142 {
143 int retval;
144 uint32_t reg;
145 struct armv7m_common *armv7m = target_to_armv7m(target);
146 struct hl_interface_s *adapter = target_to_adapter(target);
147
148 LOG_DEBUG("%s", __func__);
149
150 /* NOTE: we "know" here that the register identifiers used
151 * in the v7m header match the Cortex-M3 Debug Core Register
152 * Selector values for R0..R15, xPSR, MSP, and PSP.
153 */
154 switch (num) {
155 case 0 ... 18:
156 retval = adapter->layout->api->write_reg(adapter->handle, num, value);
157
158 if (retval != ERROR_OK) {
159 struct reg *r;
160
161 LOG_ERROR("JTAG failure");
162 r = armv7m->arm.core_cache->reg_list + num;
163 r->dirty = r->valid;
164 return ERROR_JTAG_DEVICE_ERROR;
165 }
166 LOG_DEBUG("write core reg %i value 0x%" PRIx32 "", (int)num, value);
167 break;
168
169 case ARMV7M_FPSCR:
170 /* Floating-point Status and Registers */
171 retval = target_write_u32(target, ARMV7M_SCS_DCRDR, value);
172 if (retval != ERROR_OK)
173 return retval;
174 retval = target_write_u32(target, ARMV7M_SCS_DCRSR, 33 | (1<<16));
175 if (retval != ERROR_OK)
176 return retval;
177 LOG_DEBUG("write FPSCR value 0x%" PRIx32, value);
178 break;
179
180 case ARMV7M_S0 ... ARMV7M_S31:
181 /* Floating-point Status and Registers */
182 retval = target_write_u32(target, ARMV7M_SCS_DCRDR, value);
183 if (retval != ERROR_OK)
184 return retval;
185 retval = target_write_u32(target, ARMV7M_SCS_DCRSR, (num-ARMV7M_S0+64) | (1<<16));
186 if (retval != ERROR_OK)
187 return retval;
188 LOG_DEBUG("write FPU reg S%d value 0x%" PRIx32,
189 (int)(num - ARMV7M_S0), value);
190 break;
191
192 case ARMV7M_PRIMASK:
193 case ARMV7M_BASEPRI:
194 case ARMV7M_FAULTMASK:
195 case ARMV7M_CONTROL:
196 /* Cortex-M3 packages these four registers as bitfields
197 * in one Debug Core register. So say r0 and r2 docs;
198 * it was removed from r1 docs, but still works.
199 */
200
201 adapter->layout->api->read_reg(adapter->handle, 20, &reg);
202
203 switch (num) {
204 case ARMV7M_PRIMASK:
205 buf_set_u32((uint8_t *) &reg, 0, 1, value);
206 break;
207
208 case ARMV7M_BASEPRI:
209 buf_set_u32((uint8_t *) &reg, 8, 8, value);
210 break;
211
212 case ARMV7M_FAULTMASK:
213 buf_set_u32((uint8_t *) &reg, 16, 1, value);
214 break;
215
216 case ARMV7M_CONTROL:
217 buf_set_u32((uint8_t *) &reg, 24, 2, value);
218 break;
219 }
220
221 adapter->layout->api->write_reg(adapter->handle, 20, reg);
222
223 LOG_DEBUG("write special reg %i value 0x%" PRIx32 " ", (int)num, value);
224 break;
225
226 default:
227 return ERROR_COMMAND_SYNTAX_ERROR;
228 }
229
230 return ERROR_OK;
231 }
232
233 static int adapter_examine_debug_reason(struct target *target)
234 {
235 if ((target->debug_reason != DBG_REASON_DBGRQ)
236 && (target->debug_reason != DBG_REASON_SINGLESTEP)) {
237 target->debug_reason = DBG_REASON_BREAKPOINT;
238 }
239
240 return ERROR_OK;
241 }
242
243 static int hl_dcc_read(struct hl_interface_s *hl_if, uint8_t *value, uint8_t *ctrl)
244 {
245 uint16_t dcrdr;
246 int retval = hl_if->layout->api->read_mem(hl_if->handle,
247 DCB_DCRDR, 1, sizeof(dcrdr), (uint8_t *)&dcrdr);
248 if (retval == ERROR_OK) {
249 *ctrl = (uint8_t)dcrdr;
250 *value = (uint8_t)(dcrdr >> 8);
251
252 LOG_DEBUG("data 0x%x ctrl 0x%x", *value, *ctrl);
253
254 if (dcrdr & 1) {
255 /* write ack back to software dcc register
256 * to signify we have read data */
257 /* atomically clear just the byte containing the busy bit */
258 static const uint8_t zero;
259 retval = hl_if->layout->api->write_mem(hl_if->handle, DCB_DCRDR, 1, 1, &zero);
260 }
261 }
262 return retval;
263 }
264
265 static int hl_target_request_data(struct target *target,
266 uint32_t size, uint8_t *buffer)
267 {
268 struct hl_interface_s *hl_if = target_to_adapter(target);
269 uint8_t data;
270 uint8_t ctrl;
271 uint32_t i;
272
273 for (i = 0; i < (size * 4); i++) {
274 int err = hl_dcc_read(hl_if, &data, &ctrl);
275 if (err != ERROR_OK)
276 return err;
277
278 buffer[i] = data;
279 }
280
281 return ERROR_OK;
282 }
283
284 static int hl_handle_target_request(void *priv)
285 {
286 struct target *target = priv;
287 int err;
288
289 if (!target_was_examined(target))
290 return ERROR_OK;
291 struct hl_interface_s *hl_if = target_to_adapter(target);
292
293 if (!target->dbg_msg_enabled)
294 return ERROR_OK;
295
296 if (target->state == TARGET_RUNNING) {
297 uint8_t data;
298 uint8_t ctrl;
299
300 err = hl_dcc_read(hl_if, &data, &ctrl);
301 if (err != ERROR_OK)
302 return err;
303
304 /* check if we have data */
305 if (ctrl & (1 << 0)) {
306 uint32_t request;
307
308 /* we assume target is quick enough */
309 request = data;
310 err = hl_dcc_read(hl_if, &data, &ctrl);
311 if (err != ERROR_OK)
312 return err;
313
314 request |= (data << 8);
315 err = hl_dcc_read(hl_if, &data, &ctrl);
316 if (err != ERROR_OK)
317 return err;
318
319 request |= (data << 16);
320 err = hl_dcc_read(hl_if, &data, &ctrl);
321 if (err != ERROR_OK)
322 return err;
323
324 request |= (data << 24);
325 target_request(target, request);
326 }
327 }
328
329 return ERROR_OK;
330 }
331
332 static int adapter_init_arch_info(struct target *target,
333 struct cortex_m_common *cortex_m,
334 struct jtag_tap *tap)
335 {
336 struct armv7m_common *armv7m;
337
338 LOG_DEBUG("%s", __func__);
339
340 armv7m = &cortex_m->armv7m;
341 armv7m_init_arch_info(target, armv7m);
342
343 armv7m->load_core_reg_u32 = adapter_load_core_reg_u32;
344 armv7m->store_core_reg_u32 = adapter_store_core_reg_u32;
345
346 armv7m->examine_debug_reason = adapter_examine_debug_reason;
347 armv7m->stlink = true;
348
349 target_register_timer_callback(hl_handle_target_request, 1, 1, target);
350
351 return ERROR_OK;
352 }
353
354 static int adapter_init_target(struct command_context *cmd_ctx,
355 struct target *target)
356 {
357 LOG_DEBUG("%s", __func__);
358
359 armv7m_build_reg_cache(target);
360 arm_semihosting_init(target);
361 return ERROR_OK;
362 }
363
364 static int adapter_target_create(struct target *target,
365 Jim_Interp *interp)
366 {
367 LOG_DEBUG("%s", __func__);
368 struct adiv5_private_config *pc = target->private_config;
369 if (pc != NULL && pc->ap_num > 0) {
370 LOG_ERROR("hla_target: invalid parameter -ap-num (> 0)");
371 return ERROR_COMMAND_SYNTAX_ERROR;
372 }
373
374 struct cortex_m_common *cortex_m = calloc(1, sizeof(struct cortex_m_common));
375 if (cortex_m == NULL) {
376 LOG_ERROR("No memory creating target");
377 return ERROR_FAIL;
378 }
379
380 adapter_init_arch_info(target, cortex_m, target->tap);
381
382 return ERROR_OK;
383 }
384
385 static int adapter_load_context(struct target *target)
386 {
387 struct armv7m_common *armv7m = target_to_armv7m(target);
388 int num_regs = armv7m->arm.core_cache->num_regs;
389
390 for (int i = 0; i < num_regs; i++) {
391
392 struct reg *r = &armv7m->arm.core_cache->reg_list[i];
393 if (!r->valid)
394 armv7m->arm.read_core_reg(target, r, i, ARM_MODE_ANY);
395 }
396
397 return ERROR_OK;
398 }
399
400 static int adapter_debug_entry(struct target *target)
401 {
402 struct hl_interface_s *adapter = target_to_adapter(target);
403 struct armv7m_common *armv7m = target_to_armv7m(target);
404 struct arm *arm = &armv7m->arm;
405 struct reg *r;
406 uint32_t xPSR;
407 int retval;
408
409 /* preserve the DCRDR across halts */
410 retval = target_read_u32(target, DCB_DCRDR, &target->savedDCRDR);
411 if (retval != ERROR_OK)
412 return retval;
413
414 retval = armv7m->examine_debug_reason(target);
415 if (retval != ERROR_OK)
416 return retval;
417
418 adapter_load_context(target);
419
420 /* make sure we clear the vector catch bit */
421 adapter->layout->api->write_debug_reg(adapter->handle, DCB_DEMCR, TRCENA);
422
423 r = arm->cpsr;
424 xPSR = buf_get_u32(r->value, 0, 32);
425
426 /* Are we in an exception handler */
427 if (xPSR & 0x1FF) {
428 armv7m->exception_number = (xPSR & 0x1FF);
429
430 arm->core_mode = ARM_MODE_HANDLER;
431 arm->map = armv7m_msp_reg_map;
432 } else {
433 unsigned control = buf_get_u32(arm->core_cache
434 ->reg_list[ARMV7M_CONTROL].value, 0, 2);
435
436 /* is this thread privileged? */
437 arm->core_mode = control & 1
438 ? ARM_MODE_USER_THREAD
439 : ARM_MODE_THREAD;
440
441 /* which stack is it using? */
442 if (control & 2)
443 arm->map = armv7m_psp_reg_map;
444 else
445 arm->map = armv7m_msp_reg_map;
446
447 armv7m->exception_number = 0;
448 }
449
450 LOG_DEBUG("entered debug state in core mode: %s at PC 0x%08" PRIx32 ", target->state: %s",
451 arm_mode_name(arm->core_mode),
452 buf_get_u32(arm->pc->value, 0, 32),
453 target_state_name(target));
454
455 return retval;
456 }
457
458 static int adapter_poll(struct target *target)
459 {
460 enum target_state state;
461 struct hl_interface_s *adapter = target_to_adapter(target);
462 struct armv7m_common *armv7m = target_to_armv7m(target);
463 enum target_state prev_target_state = target->state;
464
465 state = adapter->layout->api->state(adapter->handle);
466
467 if (state == TARGET_UNKNOWN) {
468 LOG_ERROR("jtag status contains invalid mode value - communication failure");
469 return ERROR_TARGET_FAILURE;
470 }
471
472 if (prev_target_state == state)
473 return ERROR_OK;
474
475 if (prev_target_state == TARGET_DEBUG_RUNNING && state == TARGET_RUNNING)
476 return ERROR_OK;
477
478 target->state = state;
479
480 if (state == TARGET_HALTED) {
481
482 int retval = adapter_debug_entry(target);
483 if (retval != ERROR_OK)
484 return retval;
485
486 if (prev_target_state == TARGET_DEBUG_RUNNING) {
487 target_call_event_callbacks(target, TARGET_EVENT_DEBUG_HALTED);
488 } else {
489 if (arm_semihosting(target, &retval) != 0)
490 return retval;
491
492 target_call_event_callbacks(target, TARGET_EVENT_HALTED);
493 }
494
495 LOG_DEBUG("halted: PC: 0x%08" PRIx32, buf_get_u32(armv7m->arm.pc->value, 0, 32));
496 }
497
498 return ERROR_OK;
499 }
500
501 static int adapter_assert_reset(struct target *target)
502 {
503 int res = ERROR_OK;
504 struct hl_interface_s *adapter = target_to_adapter(target);
505 struct armv7m_common *armv7m = target_to_armv7m(target);
506 bool use_srst_fallback = true;
507
508 LOG_DEBUG("%s", __func__);
509
510 enum reset_types jtag_reset_config = jtag_get_reset_config();
511
512 bool srst_asserted = false;
513
514 if ((jtag_reset_config & RESET_HAS_SRST) &&
515 (jtag_reset_config & RESET_SRST_NO_GATING)) {
516 jtag_add_reset(0, 1);
517 res = adapter->layout->api->assert_srst(adapter->handle, 0);
518 srst_asserted = true;
519 }
520
521 adapter->layout->api->write_debug_reg(adapter->handle, DCB_DHCSR, DBGKEY|C_DEBUGEN);
522
523 /* only set vector catch if halt is requested */
524 if (target->reset_halt)
525 adapter->layout->api->write_debug_reg(adapter->handle, DCB_DEMCR, TRCENA|VC_CORERESET);
526 else
527 adapter->layout->api->write_debug_reg(adapter->handle, DCB_DEMCR, TRCENA);
528
529 if (jtag_reset_config & RESET_HAS_SRST) {
530 if (!srst_asserted) {
531 jtag_add_reset(0, 1);
532 res = adapter->layout->api->assert_srst(adapter->handle, 0);
533 }
534 if (res == ERROR_COMMAND_NOTFOUND)
535 LOG_ERROR("Hardware srst not supported, falling back to software reset");
536 else if (res == ERROR_OK) {
537 /* hardware srst supported */
538 use_srst_fallback = false;
539 }
540 }
541
542 if (use_srst_fallback) {
543 /* stlink v1 api does not support hardware srst, so we use a software reset fallback */
544 adapter->layout->api->write_debug_reg(adapter->handle, NVIC_AIRCR, AIRCR_VECTKEY | AIRCR_SYSRESETREQ);
545 }
546
547 res = adapter->layout->api->reset(adapter->handle);
548
549 if (res != ERROR_OK)
550 return res;
551
552 /* registers are now invalid */
553 register_cache_invalidate(armv7m->arm.core_cache);
554
555 if (target->reset_halt) {
556 target->state = TARGET_RESET;
557 target->debug_reason = DBG_REASON_DBGRQ;
558 } else {
559 target->state = TARGET_HALTED;
560 }
561
562 return ERROR_OK;
563 }
564
565 static int adapter_deassert_reset(struct target *target)
566 {
567 struct hl_interface_s *adapter = target_to_adapter(target);
568
569 enum reset_types jtag_reset_config = jtag_get_reset_config();
570
571 LOG_DEBUG("%s", __func__);
572
573 if (jtag_reset_config & RESET_HAS_SRST)
574 adapter->layout->api->assert_srst(adapter->handle, 1);
575
576 /* virtual deassert reset, we need it for the internal
577 * jtag state machine
578 */
579 jtag_add_reset(0, 0);
580
581 target->savedDCRDR = 0; /* clear both DCC busy bits on initial resume */
582
583 return target->reset_halt ? ERROR_OK : target_resume(target, 1, 0, 0, 0);
584 }
585
586 static int adapter_halt(struct target *target)
587 {
588 int res;
589 struct hl_interface_s *adapter = target_to_adapter(target);
590
591 LOG_DEBUG("%s", __func__);
592
593 if (target->state == TARGET_HALTED) {
594 LOG_DEBUG("target was already halted");
595 return ERROR_OK;
596 }
597
598 if (target->state == TARGET_UNKNOWN)
599 LOG_WARNING("target was in unknown state when halt was requested");
600
601 res = adapter->layout->api->halt(adapter->handle);
602
603 if (res != ERROR_OK)
604 return res;
605
606 target->debug_reason = DBG_REASON_DBGRQ;
607
608 return ERROR_OK;
609 }
610
611 static int adapter_resume(struct target *target, int current,
612 target_addr_t address, int handle_breakpoints,
613 int debug_execution)
614 {
615 int res;
616 struct hl_interface_s *adapter = target_to_adapter(target);
617 struct armv7m_common *armv7m = target_to_armv7m(target);
618 uint32_t resume_pc;
619 struct breakpoint *breakpoint = NULL;
620 struct reg *pc;
621
622 LOG_DEBUG("%s %d " TARGET_ADDR_FMT " %d %d", __func__, current,
623 address, handle_breakpoints, debug_execution);
624
625 if (target->state != TARGET_HALTED) {
626 LOG_WARNING("target not halted");
627 return ERROR_TARGET_NOT_HALTED;
628 }
629
630 if (!debug_execution) {
631 target_free_all_working_areas(target);
632 cortex_m_enable_breakpoints(target);
633 cortex_m_enable_watchpoints(target);
634 }
635
636 pc = armv7m->arm.pc;
637 if (!current) {
638 buf_set_u32(pc->value, 0, 32, address);
639 pc->dirty = true;
640 pc->valid = true;
641 }
642
643 if (!breakpoint_find(target, buf_get_u32(pc->value, 0, 32))
644 && !debug_execution) {
645 armv7m_maybe_skip_bkpt_inst(target, NULL);
646 }
647
648 resume_pc = buf_get_u32(pc->value, 0, 32);
649
650 /* write any user vector flags */
651 res = target_write_u32(target, DCB_DEMCR, TRCENA | armv7m->demcr);
652 if (res != ERROR_OK)
653 return res;
654
655 armv7m_restore_context(target);
656
657 /* restore savedDCRDR */
658 res = target_write_u32(target, DCB_DCRDR, target->savedDCRDR);
659 if (res != ERROR_OK)
660 return res;
661
662 /* registers are now invalid */
663 register_cache_invalidate(armv7m->arm.core_cache);
664
665 /* the front-end may request us not to handle breakpoints */
666 if (handle_breakpoints) {
667 /* Single step past breakpoint at current address */
668 breakpoint = breakpoint_find(target, resume_pc);
669 if (breakpoint) {
670 LOG_DEBUG("unset breakpoint at " TARGET_ADDR_FMT " (ID: %" PRIu32 ")",
671 breakpoint->address,
672 breakpoint->unique_id);
673 cortex_m_unset_breakpoint(target, breakpoint);
674
675 res = adapter->layout->api->step(adapter->handle);
676
677 if (res != ERROR_OK)
678 return res;
679
680 cortex_m_set_breakpoint(target, breakpoint);
681 }
682 }
683
684 res = adapter->layout->api->run(adapter->handle);
685
686 if (res != ERROR_OK)
687 return res;
688
689 target->debug_reason = DBG_REASON_NOTHALTED;
690
691 if (!debug_execution) {
692 target->state = TARGET_RUNNING;
693 target_call_event_callbacks(target, TARGET_EVENT_RESUMED);
694 } else {
695 target->state = TARGET_DEBUG_RUNNING;
696 target_call_event_callbacks(target, TARGET_EVENT_DEBUG_RESUMED);
697 }
698
699 return ERROR_OK;
700 }
701
702 static int adapter_step(struct target *target, int current,
703 target_addr_t address, int handle_breakpoints)
704 {
705 int res;
706 struct hl_interface_s *adapter = target_to_adapter(target);
707 struct armv7m_common *armv7m = target_to_armv7m(target);
708 struct breakpoint *breakpoint = NULL;
709 struct reg *pc = armv7m->arm.pc;
710 bool bkpt_inst_found = false;
711
712 LOG_DEBUG("%s", __func__);
713
714 if (target->state != TARGET_HALTED) {
715 LOG_WARNING("target not halted");
716 return ERROR_TARGET_NOT_HALTED;
717 }
718
719 if (!current) {
720 buf_set_u32(pc->value, 0, 32, address);
721 pc->dirty = true;
722 pc->valid = true;
723 }
724
725 uint32_t pc_value = buf_get_u32(pc->value, 0, 32);
726
727 /* the front-end may request us not to handle breakpoints */
728 if (handle_breakpoints) {
729 breakpoint = breakpoint_find(target, pc_value);
730 if (breakpoint)
731 cortex_m_unset_breakpoint(target, breakpoint);
732 }
733
734 armv7m_maybe_skip_bkpt_inst(target, &bkpt_inst_found);
735
736 target->debug_reason = DBG_REASON_SINGLESTEP;
737
738 armv7m_restore_context(target);
739
740 /* restore savedDCRDR */
741 res = target_write_u32(target, DCB_DCRDR, target->savedDCRDR);
742 if (res != ERROR_OK)
743 return res;
744
745 target_call_event_callbacks(target, TARGET_EVENT_RESUMED);
746
747 res = adapter->layout->api->step(adapter->handle);
748
749 if (res != ERROR_OK)
750 return res;
751
752 /* registers are now invalid */
753 register_cache_invalidate(armv7m->arm.core_cache);
754
755 if (breakpoint)
756 cortex_m_set_breakpoint(target, breakpoint);
757
758 adapter_debug_entry(target);
759 target_call_event_callbacks(target, TARGET_EVENT_HALTED);
760
761 LOG_INFO("halted: PC: 0x%08" PRIx32, buf_get_u32(armv7m->arm.pc->value, 0, 32));
762
763 return ERROR_OK;
764 }
765
766 static int adapter_read_memory(struct target *target, target_addr_t address,
767 uint32_t size, uint32_t count,
768 uint8_t *buffer)
769 {
770 struct hl_interface_s *adapter = target_to_adapter(target);
771
772 if (!count || !buffer)
773 return ERROR_COMMAND_SYNTAX_ERROR;
774
775 LOG_DEBUG("%s " TARGET_ADDR_FMT " %" PRIu32 " %" PRIu32,
776 __func__, address, size, count);
777
778 return adapter->layout->api->read_mem(adapter->handle, address, size, count, buffer);
779 }
780
781 static int adapter_write_memory(struct target *target, target_addr_t address,
782 uint32_t size, uint32_t count,
783 const uint8_t *buffer)
784 {
785 struct hl_interface_s *adapter = target_to_adapter(target);
786
787 if (!count || !buffer)
788 return ERROR_COMMAND_SYNTAX_ERROR;
789
790 LOG_DEBUG("%s " TARGET_ADDR_FMT " %" PRIu32 " %" PRIu32,
791 __func__, address, size, count);
792
793 return adapter->layout->api->write_mem(adapter->handle, address, size, count, buffer);
794 }
795
796 static const struct command_registration adapter_command_handlers[] = {
797 {
798 .chain = arm_command_handlers,
799 },
800 {
801 .chain = armv7m_trace_command_handlers,
802 },
803 COMMAND_REGISTRATION_DONE
804 };
805
806 struct target_type hla_target = {
807 .name = "hla_target",
808 .deprecated_name = "stm32_stlink",
809
810 .init_target = adapter_init_target,
811 .deinit_target = cortex_m_deinit_target,
812 .target_create = adapter_target_create,
813 .target_jim_configure = adiv5_jim_configure,
814 .examine = cortex_m_examine,
815 .commands = adapter_command_handlers,
816
817 .poll = adapter_poll,
818 .arch_state = armv7m_arch_state,
819
820 .target_request_data = hl_target_request_data,
821 .assert_reset = adapter_assert_reset,
822 .deassert_reset = adapter_deassert_reset,
823
824 .halt = adapter_halt,
825 .resume = adapter_resume,
826 .step = adapter_step,
827
828 .get_gdb_arch = arm_get_gdb_arch,
829 .get_gdb_reg_list = armv7m_get_gdb_reg_list,
830
831 .read_memory = adapter_read_memory,
832 .write_memory = adapter_write_memory,
833 .checksum_memory = armv7m_checksum_memory,
834 .blank_check_memory = armv7m_blank_check_memory,
835
836 .run_algorithm = armv7m_run_algorithm,
837 .start_algorithm = armv7m_start_algorithm,
838 .wait_algorithm = armv7m_wait_algorithm,
839
840 .add_breakpoint = cortex_m_add_breakpoint,
841 .remove_breakpoint = cortex_m_remove_breakpoint,
842 .add_watchpoint = cortex_m_add_watchpoint,
843 .remove_watchpoint = cortex_m_remove_watchpoint,
844 .profiling = cortex_m_profiling,
845 };

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)