From: kevin Date: Mon, 17 Oct 2016 11:46:26 +0000 (+0100) Subject: flash/nor/efm32: Support flash size smaller than 32k X-Git-Tag: v0.10.0-rc1~28 X-Git-Url: https://review.openocd.org/gitweb?a=commitdiff_plain;h=c37a88c92f0234df6206a4b58c23d20563a22afc;p=openocd.git flash/nor/efm32: Support flash size smaller than 32k The current implementation fails on devices with less than 32k of flash (such as several devices in the Zero Gecko family) because the 'assert' assumes (incorrectly) that the number of flash banks will always be >= 32. This change ensures that at least one word of lock bits is always read in order to support devices with less than 32k of flash. Signed-off-by: Kevlar Harness Change-Id: I59febe2cb690c893a5057a5f72918e146cf2afe4 Reviewed-on: http://openocd.zylin.com/3806 Tested-by: jenkins Reviewed-by: Marc Schink Reviewed-by: Paul Fertser --- diff --git a/src/flash/nor/efm32.c b/src/flash/nor/efm32.c index 0b33829bae..81c1a379cc 100644 --- a/src/flash/nor/efm32.c +++ b/src/flash/nor/efm32.c @@ -456,10 +456,10 @@ static int efm32x_read_lock_data(struct flash_bank *bank) uint32_t *ptr = NULL; int ret = 0; - assert(!(bank->num_sectors & 0x1f)); + assert(bank->num_sectors > 0); - data_size = bank->num_sectors / 8; /* number of data bytes */ - data_size /= 4; /* ...and data dwords */ + /* calculate the number of 32-bit words to read (one lock bit per sector) */ + data_size = (bank->num_sectors + 31) / 32; ptr = efm32x_info->lb_page;