From: oharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Date: Fri, 8 May 2009 06:14:08 +0000 (+0000)
Subject: added comments w.r.t. potential performance problems
X-Git-Tag: v0.2.0~842
X-Git-Url: https://review.openocd.org/gitweb?a=commitdiff_plain;ds=inline;h=75f98d16494849f9e102a67e7820075b60aeb9b1;p=openocd.git

added comments w.r.t. potential performance problems

git-svn-id: svn://svn.berlios.de/openocd/trunk@1663 b42882b7-edfa-0310-969c-e2dbd0fdcd60
---

diff --git a/src/target/arm7tdmi.c b/src/target/arm7tdmi.c
index 5f45ad9977..647e68b9eb 100644
--- a/src/target/arm7tdmi.c
+++ b/src/target/arm7tdmi.c
@@ -372,6 +372,13 @@ void arm7tdmi_change_to_arm(target_t *target, u32 *r0, u32 *pc)
 	*pc -= 0xa;
 }
 
+
+/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many
+ * roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s?
+ *
+ * The solution is to arrange for a large out/in scan in this loop and
+ * and convert data afterwards.
+ */
 void arm7tdmi_read_core_regs(target_t *target, u32 mask, u32* core_regs[16])
 {
 	int i;
diff --git a/src/target/arm_adi_v5.c b/src/target/arm_adi_v5.c
index c1555d9f88..871caefc3a 100644
--- a/src/target/arm_adi_v5.c
+++ b/src/target/arm_adi_v5.c
@@ -867,6 +867,12 @@ int mem_ap_read_buf_u16(swjdp_common_t *swjdp, u8 *buffer, int count, u32 addres
 	return retval;
 }
 
+/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many
+ * roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s?
+ *
+ * The solution is to arrange for a large out/in scan in this loop and
+ * and convert data afterwards.
+ */
 int mem_ap_read_buf_packed_u8(swjdp_common_t *swjdp, u8 *buffer, int count, u32 address)
 {
 	u32 invalue;