X-Git-Url: https://review.openocd.org/gitweb?a=blobdiff_plain;f=src%2Ftarget%2Ftarget.c;h=baf57565cc9988e06dec1ec84aba9689e36c0e8d;hb=e199d7bd2cd8a9c9dead86ad293ebf3dfd8be33a;hp=8901cd1125966ff999d6cb852140390d31b79f97;hpb=5cc4601c5f356af02571db240e2f70be908399f6;p=openocd.git

diff --git a/src/target/target.c b/src/target/target.c
index 8901cd1125..baf57565cc 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -49,6 +49,7 @@
 
 int cli_target_callback_event_handler(struct target_s *target, enum target_event event, void *priv);
 
+
 int handle_target_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
 int handle_daemon_startup_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
 int handle_targets_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
@@ -87,6 +88,7 @@ extern target_type_t arm926ejs_target;
 extern target_type_t feroceon_target;
 extern target_type_t xscale_target;
 extern target_type_t cortexm3_target;
+extern target_type_t arm11_target;
 
 target_type_t *target_types[] =
 {
@@ -99,6 +101,7 @@ target_type_t *target_types[] =
 	&feroceon_target,
 	&xscale_target,
 	&cortexm3_target,
+	&arm11_target,
 	NULL,
 };
 
@@ -119,7 +122,7 @@ char *target_debug_reason_strings[] =
 {
 	"debug request", "breakpoint", "watchpoint",
 	"watchpoint and breakpoint", "single step",
-	"target not halted"
+	"target not halted", "undefined"
 };
 
 char *target_endianess_strings[] =
@@ -226,7 +229,7 @@ int target_init_handler(struct target_s *target, enum target_event event, void *
 	{
 		target_unregister_event_callback(target_init_handler, priv);
 
-		script = open_file_from_path(cmd_ctx, target->reset_script, "r");
+		script = open_file_from_path(target->reset_script, "r");
 		if (!script)
 		{
 			ERROR("couldn't open script file %s", target->reset_script);
@@ -267,11 +270,11 @@ int target_process_reset(struct command_context_s *cmd_ctx)
 			switch (target->reset_mode)
 			{
 				case RESET_HALT:
-					command_print(cmd_ctx, "nSRST pulls nTRST, falling back to RESET_RUN_AND_HALT");
+					command_print(cmd_ctx, "nSRST pulls nTRST, falling back to \"reset run_and_halt\"");
 					target->reset_mode = RESET_RUN_AND_HALT;
 					break;
 				case RESET_INIT:
-					command_print(cmd_ctx, "nSRST pulls nTRST, falling back to RESET_RUN_AND_INIT");
+					command_print(cmd_ctx, "nSRST pulls nTRST, falling back to \"reset run_and_init\"");
 					target->reset_mode = RESET_RUN_AND_INIT;
 					break;
 				default:
@@ -359,7 +362,9 @@ int target_process_reset(struct command_context_s *cmd_ctx)
 						command_print(cmd_ctx, "Timed out waiting for reset");
 						goto done;
 					}
-					usleep(100*1000); /* Do not eat all cpu */
+					/* this will send alive messages on e.g. GDB remote protocol. */
+					usleep(500*1000); 
+					USER_N("%s", ""); /* avoid warning about zero length formatting message*/ 
 					goto again;
 				}
 			}
@@ -387,7 +392,6 @@ static int default_virt2phys(struct target_s *target, u32 virtual, u32 *physical
 
 static int default_mmu(struct target_s *target, int *enabled)
 {
-	USER("No MMU present");
 	*enabled = 0;
 	return ERROR_OK;
 }
@@ -752,6 +756,24 @@ int target_register_commands(struct command_context_s *cmd_ctx)
 	return ERROR_OK;
 }
 
+int target_arch_state(struct target_s *target)
+{
+	int retval;
+	if (target==NULL)
+	{
+		USER("No target has been configured");
+		return ERROR_OK;
+	}
+	
+	USER("target state: %s", target_state_strings[target->state]);
+	
+	if (target->state!=TARGET_HALTED)
+		return ERROR_OK;
+	
+	retval=target->type->arch_state(target);
+	return retval;
+}
+
 /* Single aligned words are guaranteed to use 16 or 32 bit access 
  * mode respectively, otherwise data is handled as quickly as 
  * possible
@@ -772,6 +794,9 @@ int target_write_buffer(struct target_s *target, u32 address, u32 size, u8 *buff
 	{
 		int unaligned = 4 - (address % 4);
 		
+		if (unaligned > size)
+			unaligned = size;
+
 		if ((retval = target->type->write_memory(target, address, 1, unaligned, buffer)) != ERROR_OK)
 			return retval;
 		
@@ -833,6 +858,9 @@ int target_read_buffer(struct target_s *target, u32 address, u32 size, u8 *buffe
 	{
 		int unaligned = 4 - (address % 4);
 		
+		if (unaligned > size)
+			unaligned = size;
+
 		if ((retval = target->type->read_memory(target, address, 1, unaligned, buffer)) != ERROR_OK)
 			return retval;
 		
@@ -1152,6 +1180,7 @@ int handle_target_command(struct command_context_s *cmd_ctx, char *cmd, char **a
 				(*last_target_p)->backup_working_area = 0;
 				
 				(*last_target_p)->state = TARGET_UNKNOWN;
+				(*last_target_p)->debug_reason = DBG_REASON_UNDEFINED;
 				(*last_target_p)->reg_cache = NULL;
 				(*last_target_p)->breakpoints = NULL;
 				(*last_target_p)->watchpoints = NULL;
@@ -1319,9 +1348,9 @@ int handle_target(void *priv)
 		if (target->state != TARGET_HALTED)
 		{
 			if (target_continous_poll)
-				if ((retval = target->type->poll(target)) < 0)
+				if ((retval = target->type->poll(target)) != ERROR_OK)
 				{
-					ERROR("couldn't poll target. It's due for a reset.");
+					ERROR("couldn't poll target(%d). It's due for a reset.", retval);
 				}
 		}
 	
@@ -1458,17 +1487,11 @@ static int wait_state(struct command_context_s *cmd_ctx, char *cmd, enum target_
 int handle_poll_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
 {
 	target_t *target = get_current_target(cmd_ctx);
-	char buffer[512];
 
 	if (argc == 0)
 	{
-		command_print(cmd_ctx, "target state: %s", target_state_strings[target->type->poll(target)]);
-		if (target->state == TARGET_HALTED)
-		{
-			target->type->arch_state(target, buffer, 512);
-			buffer[511] = 0;
-			command_print(cmd_ctx, "%s", buffer);
-		}
+		target->type->poll(target);
+			target_arch_state(target);
 	}
 	else
 	{
@@ -1518,26 +1541,31 @@ static void target_process_events(struct command_context_s *cmd_ctx)
 
 static int wait_state(struct command_context_s *cmd_ctx, char *cmd, enum target_state state, int ms)
 {
+	int retval;
 	struct timeval timeout, now;
-	
+	int once=1;
 	gettimeofday(&timeout, NULL);
 	timeval_add_time(&timeout, 0, ms * 1000);
-	command_print(cmd_ctx, "waiting for target %s...", target_state_strings[state]);
 	
 	target_t *target = get_current_target(cmd_ctx);
-	while (target->type->poll(target))
+	for (;;)
 	{
+		if ((retval=target->type->poll(target))!=ERROR_OK)
+			return retval;
 		target_call_timer_callbacks();
 		if (target->state == state)
 		{
-			command_print(cmd_ctx, "target %s", target_state_strings[state]);
 			break;
 		}
+		if (once)
+		{
+			once=0;
+			command_print(cmd_ctx, "waiting for target %s...", target_state_strings[state]);
+		}
 		
 		gettimeofday(&now, NULL);
 		if ((now.tv_sec > timeout.tv_sec) || ((now.tv_sec == timeout.tv_sec) && (now.tv_usec >= timeout.tv_usec)))
 		{
-			command_print(cmd_ctx, "timed out while waiting for target %s", target_state_strings[state]);
 			ERROR("timed out while waiting for target %s", target_state_strings[state]);
 			break;
 		}
@@ -1552,24 +1580,11 @@ int handle_halt_command(struct command_context_s *cmd_ctx, char *cmd, char **arg
 	target_t *target = get_current_target(cmd_ctx);
 
 	DEBUG("-");
-	
-	command_print(cmd_ctx, "requesting target halt...");
 
 	if ((retval = target->type->halt(target)) != ERROR_OK)
-	{	
-		switch (retval)
 		{
-			case ERROR_TARGET_ALREADY_HALTED:
-				command_print(cmd_ctx, "target already halted");
-				break;
-			case ERROR_TARGET_TIMEOUT:
-				command_print(cmd_ctx, "target timed out... shutting down");
-				return retval;
-			default:
-				command_print(cmd_ctx, "unknown error... shutting down");
 				return retval;
 		}
-	}
 	
 	return handle_wait_halt_command(cmd_ctx, cmd, args, argc);
 }
@@ -1675,34 +1690,18 @@ int handle_resume_command(struct command_context_s *cmd_ctx, char *cmd, char **a
 	int retval;
 	target_t *target = get_current_target(cmd_ctx);
 	
-	DEBUG("-");
-	
 	if (argc == 0)
 		retval = target->type->resume(target, 1, 0, 1, 0); /* current pc, addr = 0, handle breakpoints, not debugging */
 	else if (argc == 1)
 		retval = target->type->resume(target, 0, strtoul(args[0], NULL, 0), 1, 0); /* addr = args[0], handle breakpoints, not debugging */
 	else
 	{
-		command_print(cmd_ctx, "usage: resume [address]");
-		return ERROR_OK;
-	}
-	
-	if (retval != ERROR_OK)
-	{	
-		switch (retval)
-		{
-			case ERROR_TARGET_NOT_HALTED:
-				command_print(cmd_ctx, "target not halted");
-				break;
-			default:
-				command_print(cmd_ctx, "unknown error... shutting down");
-				exit(-1);
-		}
+		return ERROR_COMMAND_SYNTAX_ERROR;
 	}
 
 	target_process_events(cmd_ctx);
 	
-	return ERROR_OK;
+	return retval;
 }
 
 int handle_step_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
@@ -1907,7 +1906,6 @@ int handle_load_image_command(struct command_context_s *cmd_ctx, char *cmd, char
 	
 	if (image_open(&image, args[0], (argc >= 3) ? args[2] : NULL) != ERROR_OK)
 	{
-		command_print(cmd_ctx, "load_image error: %s", image.error_str);
 		return ERROR_OK;
 	}
 	
@@ -1977,7 +1975,6 @@ int handle_dump_image_command(struct command_context_s *cmd_ctx, char *cmd, char
 	
 	if (fileio_open(&fileio, args[0], FILEIO_WRITE, FILEIO_BINARY) != ERROR_OK)
 	{
-		command_print(cmd_ctx, "dump_image error: %s", fileio.error_str);
 		return ERROR_OK;
 	}
 	
@@ -2056,7 +2053,6 @@ int handle_verify_image_command(struct command_context_s *cmd_ctx, char *cmd, ch
 
 	if (image_open(&image, args[0], (argc == 3) ? args[2] : NULL) != ERROR_OK)
 	{
-		command_print(cmd_ctx, "verify_image error: %s", image.error_str);
 		return ERROR_OK;
 	}