X-Git-Url: https://review.openocd.org/gitweb?a=blobdiff_plain;f=src%2Ftarget%2Fadi_v5_swd.c;h=6af77488481098931f561433cb76bd962ebaaaf8;hb=b00b9f2d7d2805ce0d038b2149b636c0576ee9ec;hp=5a3570d536f457734f084fcbb0e408ef78c9afa0;hpb=c8b57198025c414f8d19577e6846021843c2a751;p=openocd.git diff --git a/src/target/adi_v5_swd.c b/src/target/adi_v5_swd.c index 5a3570d536..6af7748848 100644 --- a/src/target/adi_v5_swd.c +++ b/src/target/adi_v5_swd.c @@ -55,12 +55,10 @@ #include - - static int swd_queue_dp_read(struct adiv5_dap *dap, unsigned reg, uint32_t *data) { - // REVISIT status return vs ack ... + /* REVISIT status return vs ack ... */ return swd->read_reg(swd_cmd(true, false, reg), data); } @@ -71,14 +69,14 @@ static int swd_queue_idcode_read(struct adiv5_dap *dap, if (status < 0) return status; *ack = status; - // ?? + /* ?? */ return ERROR_OK; } static int (swd_queue_dp_write)(struct adiv5_dap *dap, unsigned reg, uint32_t data) { - // REVISIT status return vs ack ... + /* REVISIT status return vs ack ... */ return swd->write_reg(swd_cmd(false, false, reg), data); } @@ -86,16 +84,16 @@ static int (swd_queue_dp_write)(struct adiv5_dap *dap, unsigned reg, static int (swd_queue_ap_read)(struct adiv5_dap *dap, unsigned reg, uint32_t *data) { - // REVISIT APSEL ... - // REVISIT status return ... + /* REVISIT APSEL ... */ + /* REVISIT status return ... */ return swd->read_reg(swd_cmd(true, true, reg), data); } static int (swd_queue_ap_write)(struct adiv5_dap *dap, unsigned reg, uint32_t data) { - // REVISIT APSEL ... - // REVISIT status return ... + /* REVISIT APSEL ... */ + /* REVISIT status return ... */ return swd->write_reg(swd_cmd(false, true, reg), data); } @@ -194,15 +192,14 @@ COMMAND_HANDLER(handle_swd_wcr) int retval; struct target *target = get_current_target(CMD_CTX); struct arm *arm = target_to_arm(target); -struct adiv5_dap *dap = arm->dap; + struct adiv5_dap *dap = arm->dap; uint32_t wcr; unsigned trn, scale = 0; - switch (CMD_ARGC) { /* no-args: just dump state */ case 0: - //retval = swd_queue_dp_read(dap, DP_WCR, &wcr); + /*retval = swd_queue_dp_read(dap, DP_WCR, &wcr); */ retval = dap_queue_dp_read(dap, DP_WCR, &wcr); if (retval == ERROR_OK) dap->ops->run(dap); @@ -315,11 +312,10 @@ static int swd_init(struct command_context *ctx) { struct target *target = get_current_target(ctx); struct arm *arm = target_to_arm(target); -struct adiv5_dap *dap = arm->dap; + struct adiv5_dap *dap = arm->dap; uint32_t idcode; int status; - /* FIXME validate transport config ... is the * configured DAP present (check IDCODE)? * Is *only* one DAP configured?