X-Git-Url: https://review.openocd.org/gitweb?a=blobdiff_plain;f=HACKING;h=0bea65a751c673f329bc5f4e2ef244e32137c96f;hb=a4cdce0129a6b206a2081d77dd518ce2cae0b71f;hp=c2e841ab52612aaf6d5a0e7f0b8e8516429791dd;hpb=906d6aaa198e7e28c3cf4123e4ee56315da66df2;p=openocd.git diff --git a/HACKING b/HACKING index c2e841ab52..0bea65a751 100644 --- a/HACKING +++ b/HACKING @@ -1,13 +1,20 @@ // This file is part of the Doxygen Developer Manual /** @page patchguide Patch Guidelines -\attention If you're behind a corporate wall with http only access to the -world, you can still use these instructions! - \attention You can't send patches to the mailing list anymore at all. Nowadays you are expected to send patches to the OpenOCD Gerrit GIT server for a review. +\attention If you already have a Gerrit account and want to try a +different sign in method, please first sign in as usually, press your +name in the upper-right corner, go to @a Settings, select @a +Identities pane, press Link Another Identity button. In case +you already have duplicated accounts, ask administrators for manual +merging. + +\attention If you're behind a corporate wall with http only access to the +world, you can still use these instructions! + @section gerrit Submitting patches to the OpenOCD Gerrit server OpenOCD is to some extent a "self service" open source project, so to @@ -172,6 +179,13 @@ not have to) be disregarded if all conditions listed below are met: @section browsing Browsing Patches All OpenOCD patches can be reviewed here. + +@section reviewing Reviewing Patches +From the main Review +page select the patch you want to review and click on that patch. On the +appearing page select the download method (top right). Apply the +patch. After building and testing you can leave a note with the "Reply" +button and mark the patch with -1, 0 and +1. */ /** @file This file contains the @ref patchguide page.